Conversation
ahoy-jon
commented
Sep 21, 2025
ahoy-jon
commented
Oct 3, 2025
ahoy-jon
commented
Oct 3, 2025
steinybot
reviewed
Oct 8, 2025
hearnadam
reviewed
Jan 3, 2026
Comment on lines
+320
to
+321
| case FromKyo(kyo) => kyo() | ||
| case FromKyo_0(kyo) => kyo() |
Collaborator
There was a problem hiding this comment.
Since these will be materialized to the same expected type - I don't think we need a distinct variant. Can we keep it as just FromKyo?
Collaborator
Author
There was a problem hiding this comment.
That would be nice, but Env[Nothing] will not be helpful.
Collaborator
There was a problem hiding this comment.
I think we can just cast. There's no difference in the underlying representation due to type widening.
…d fix type arguments for `provide`
…djust README accordingly
- Updated `andTo` method implementation to use a more consistent syntax. - Replaced deprecated `using` method with a direct call to `andTo`. - Removed unused `AndTo` case class from the `Layer` object. - Adjusted test cases to reflect the changes in method usage.
- Changed references of `andTo` to `using` in the documentation. - Updated example code to reflect the new method name and its usage. - Ensured consistency in method descriptions for better understanding.
hearnadam
reviewed
Feb 6, 2026
| final infix def using[Out2, S2, In2](that: Layer[Out2, Env[In2] & S2]): Layer[Out & Out2, S & S2] = self and (self to that) | ||
| final infix def andTo[Out2, S2](that: Layer[Out2, Env[Out] & S2]): Layer[Out & Out2, S & S2] = self and (self to that) | ||
|
|
||
| final infix def using[Out2, S2](that: Layer[Out2, Env[Out] & S2]): Layer[Out & Out2, S & S2] = self andTo that |
Comment on lines
+320
to
+321
| case FromKyo(kyo) => kyo() | ||
| case FromKyo_0(kyo) => kyo() |
Collaborator
There was a problem hiding this comment.
I think we can just cast. There's no difference in the underlying representation due to type widening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.