feat: Add NestedHandlerTest to validate Nested behavior and enhance A…#1493
Open
feat: Add NestedHandlerTest to validate Nested behavior and enhance A…#1493
Conversation
ahoy-jon
commented
Mar 23, 2026
ahoy-jon
force-pushed
the
1412-bug-freeze-on-unnecessary-handling-for-var
branch
from
08f4178 to
ffcd186
Compare
ahoy-jon
force-pushed
the
1412-bug-freeze-on-unnecessary-handling-for-var
branch
from
ffcd186 to
78267fd
Compare
…rrowEffect with Nested case handling
ahoy-jon
force-pushed
the
1412-bug-freeze-on-unnecessary-handling-for-var
branch
from
78267fd to
857eefc
Compare
hearnadam
reviewed
Mar 26, 2026
|
|
||
| def flatten[A, B, C](v: A < B < C): A < (B & C) = v.map(a => a) | ||
|
|
||
| "handle on Nested (unsafeGet path)" - { |
Collaborator
There was a problem hiding this comment.
Suggested change
| "handle on Nested (unsafeGet path)" - { | |
| "not handle Nested" - { |
| import kyo.kernel.* | ||
| import kyo.kernel.internal.* | ||
|
|
||
| class ArrowEffectNestedTest extends Test: |
Collaborator
There was a problem hiding this comment.
Maybe this belongs in ArrowEffect as a nested Suite?
Collaborator
There was a problem hiding this comment.
Agreed. Let's avoid creating ad-hoc test classes, test files should have corresponding source files.
fwbrasil
reviewed
Mar 27, 2026
| end new | ||
| case kyo => | ||
| kyo.asInstanceOf[A] | ||
| kyo.unsafeGet |
fwbrasil
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick proposal,
Fix for #1412