Skip to content

SNS: Fixing tag format in AWS Config resource items #10136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rondodev wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

SNS: Fixing tag format in AWS Config resource items #10136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbda0bf
Aligning AWS Config tags
rondodev Jul 27, 2026
7e7111f
Merge branch 'master' into fix/sns_tags
rondodev Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion moto/sns/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,7 @@ def get_config_resource(self, resource_id: str) -> dict[str, Any] | None:
"arn": topic.arn,
"awsRegion": self.region_name,
"availabilityZone": "Not Applicable",
"tags": dict(topic._tags),
"configuration": {
"topicArn": topic.arn,
"displayName": topic.display_name,
Expand All @@ -1284,7 +1285,7 @@ def get_config_resource(self, resource_id: str) -> dict[str, Any] | None:
},
"supplementaryConfiguration": {
"Tags": json.dumps(
[{"Key": k, "Value": v} for k, v in topic._tags.items()]
[{"key": k, "value": v} for k, v in topic._tags.items()]
)
},
"configurationItemMD5Hash": "",
Expand Down
7 changes: 6 additions & 1 deletion tests/test_sns/test_topics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,12 @@ def test_get_config_resource():
assert configuration["fifoTopic"] is True
assert configuration["contentBasedDeduplication"] is True
tags = json.loads(config_item["supplementaryConfiguration"]["Tags"])
assert tags == [{"Key": "Environment", "Value": "Test"}]
assert tags == [{"key": "Environment", "value": "Test"}]

history = config_client.get_resource_config_history(
resourceType="AWS::SNS::Topic", resourceId=topic_arn
)
assert history["configurationItems"][0]["tags"] == {"Environment": "Test"}

response = config_client.batch_get_resource_config(
resourceKeys=[
Expand Down
Loading