Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moto/firehose/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ def update_destination(
break
destination_idx += 1
else:
raise InvalidArgumentException("Destination Id {destination_id} not found")
raise InvalidArgumentException(f"Destination Id {destination_id} not found")

# Switching between Amazon ES and other services is not supported.
# For an Amazon ES destination, you can only update to another Amazon
Expand Down
12 changes: 12 additions & 0 deletions tests/test_firehose/test_firehose.py
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,18 @@ def test_update_destination():
"supported at this time"
) in err["Message"]

# An unknown destination id is reported back with the id that was given.
with pytest.raises(ClientError) as exc:
client.update_destination(
DeliveryStreamName=stream_name,
CurrentDeliveryStreamVersionId="1",
DestinationId="destinationId-000000000009",
ExtendedS3DestinationUpdate=s3_dest_config,
)
err = exc.value.response["Error"]
assert err["Code"] == "InvalidArgumentException"
assert "Destination Id destinationId-000000000009 not found" in err["Message"]


@mock_aws
def test_lookup_name_from_arn():
Expand Down