Toggle button styling for table/map control #1371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
commented
Oct 20, 2025
| </label> | ||
| </div> | ||
| <!-- eslint-disable-next-line vuejs-accessibility/click-events-have-key-events, vue/require-explicit-emits --> | ||
| <label v-for="{ value, text } of options" :key="value" class="btn btn-toggle" :class="{ disabled, active: model === value }" @click="$emit('update:model-value', value)"> |
There was a problem hiding this comment.
clicking the label changes the state of below hidden radio button (done by bootstrap) but model update event is not emitted.
sadiqkhoja
commented
Oct 20, 2025
| <span>{{ text }}</span> | ||
| </label> | ||
| </div> | ||
| <!-- eslint-disable-next-line vuejs-accessibility/click-events-have-key-events, vue/require-explicit-emits --> |
There was a problem hiding this comment.
click-events-have-key-events: not required as user can use arrow keys to toggle.
require-explicit-emits: model definition implicitly does that
sadiqkhoja
force-pushed
the
fixes/1344-toggle-button-styling
branch
from
7567b0c to
2c8445f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#1344
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes