Skip to content

Commit

Permalink
type=newtab
Browse files Browse the repository at this point in the history
  • Loading branch information
getrebuild committed Nov 18, 2023
1 parent fc4941f commit d247262
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions src/main/resources/web/assets/js/charts/charts.js
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ class ApprovalList extends BaseChart {
<tbody>
{data.data.map((item, idx) => {
return (
<tr key={'approval-' + idx}>
<tr key={`approval-${idx}`}>
<td className="user-avatar cell-detail user-info">
<img src={`${rb.baseUrl}/account/user-avatar/${item[0]}`} alt="Avatar" />
<span>{item[1]}</span>
Expand All @@ -689,7 +689,9 @@ class ApprovalList extends BaseChart {
</span>
</td>
<td className="cell-detail">
<a href={`${rb.baseUrl}/app/redirect?id=${item[3]}`}>{item[4]}</a>
<a href={`${rb.baseUrl}/app/redirect?id=${item[3]}&type=newtab`} target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
{item[4]}
</a>
<span className="cell-detail-description">{item[6]}</span>
</td>
<td className="actions text-right text-nowrap">
Expand Down Expand Up @@ -795,7 +797,7 @@ class FeedsSchedule extends BaseChart {
}

return (
<tr key={'schedule-' + idx}>
<tr key={`schedule-${idx}`}>
<td>
<a href={`${rb.baseUrl}/app/redirect?id=${item.id}`} className="content text-break" dangerouslySetInnerHTML={{ __html: item.content }} />
</td>
Expand Down Expand Up @@ -1118,10 +1120,7 @@ class ProjectTasks extends BaseChart {

$.post('/app/entity/common-save', JSON.stringify(data), (res) => {
if (res.error_code > 0) return RbHighbar.error(res.error_msg)
$target
.parents('tr')
.removeClass('status-0 status-1')
.addClass('status-' + data.status)
$target.parents('tr').removeClass('status-0 status-1').addClass(`status-${data.status}`)
})
}
}
Expand Down Expand Up @@ -1231,7 +1230,7 @@ class DataList extends BaseChart {
data-id={lastCell.id}
onDoubleClick={(e) => {
$stopEvent(e, true)
window.open(`${rb.baseUrl}/app/redirect?id=${lastCell.id}`)
window.open(`${rb.baseUrl}/app/redirect?id=${lastCell.id}&type=newtab`)
}}>
{row.map((c, idx) => {
if (idx === lastIndex) return null // Last is ID
Expand Down

0 comments on commit d247262

Please sign in to comment.