Set POSTGRES_HOST_AUTH_METHOD environment variable #4740
Conversation
Redash's docker-compose file will no longer bring up an environment from a cold start due to recent upstream changes to the postgres image that force the user to either set a password for the default superuser or opt-in to allowing all connections without a password via environment variable. Upstream PR: docker-library/postgres#658 Related Discussion: docker-library/postgres#681
There was a problem hiding this comment.
Thank you for addressing this!
Let's set the password instead. While it might break some existing dev setups (if they used this as a data source), but it's better to stick to best practices. While this is only dev setup, some people might use it for non dev work or with confidential information.
Beside the change in docker-compose.yml you will need to update the connection string in REDASH_DATABASE_URL.
To make things a bit more clear, let's use this-is-for-dev-only-dont-use-for-production as password :)
There was a problem hiding this comment.
On second thought, once the Postgres data directory is created, it will set the password value and won't read it again from POSTGRES_PASSWORD. So if we do this change now, we will break every existing dev setup -- regardless of the Postgres image version they are using.
Let's move on with the current change, and hope people realize they aren't supposed to use dev setup for anything but dev.
What type of PR is this? (check all applicable)
Description
Fixes #4739. Runs the postgres container with the environment variable
POSTGRES_HOST_AUTH_METHODset to the valuetrust.Setting this environment variable is not recommended by the image maintainers, but results in a postgres container that operates in much the same way that it did before the change was introduced. It is also backwards-compatible with older copies of the
postgres:9.5-alpineimage, which will simply ignore the environment variable.Related Tickets & Documents
POSTGRES_PASSWORDis unset like mysql docker-library/postgres#658Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A