Skip to content

Fix counter visualization not working on Safari #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniellangnet wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix counter visualization not working on Safari #5236

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4971d3e
Fix counter visualization not working on Safari
daniellangnet Oct 25, 2020
cf255ba
Fix counter visualization not working on Safari
daniellangnet Oct 25, 2020
c34beff
Merge branch 'master' into fix-counter-safari
justinclift Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions client/app/components/dashboards/dashboard-grid.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
> .visualization-renderer-wrapper {
flex-grow: 1;
position: relative;
height: 0;
Copy link
Collaborator

@kravets-levko kravets-levko Oct 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try just this fix - for me it worked without others (also, I tried in Chrome a minute ago - it was fine too). If it works - let's not touch other styles.

Copy link
Contributor Author

@daniellangnet daniellangnet Oct 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only works in connection with this other change for me: https://github.com/getredash/redash/pull/5236/files#diff-4e9dd1634afb5937186e1247809856826568d835e2167e33be776e08ae6ffc94L6

Everything else we could get rid of though

}

> .filters-wrapper {
Expand All @@ -113,19 +114,15 @@
overflow: hidden;
}

.counter-visualization-container {
height: 100%;

.counter-visualization-content {
position: absolute;
left: 10px;
top: 15px;
right: 10px;
bottom: 15px;
height: auto;
overflow: hidden;
padding: 0;
}
.counter-visualization-content {
position: absolute;
left: 10px;
top: 15px;
right: 10px;
bottom: 15px;
height: auto;
overflow: hidden;
padding: 0;
}
}

Expand Down
1 change: 0 additions & 1 deletion viz-lib/src/visualizations/counter/render.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
text-align: center;
padding: 15px 10px;
overflow: hidden;
position: relative;

.counter-visualization-content {
margin: 0;
Expand Down