Skip to content

Conversation

@yoshiokatsuneo
Copy link
Contributor

@yoshiokatsuneo yoshiokatsuneo commented Apr 28, 2025

What type of PR is this?

  • Feature

Description

At now, maximum date range option is "last 12 months".
But, it is quite convenient if I can view longer period like 10 years.

This PR add "Last 10 years" option to date range option.

How is this tested?

  • Manually

I run following query with Date Range parameter.

select '{{DATE_RANGE.start}}', '{{DATE_RANGE.end}}'

Set Date Range to 10 years.
image

And, I confirmed that output is correctly shown like below.

'2015-04-28' | '2025-04-28' |  

@yoshiokatsuneo yoshiokatsuneo force-pushed the feat/add_last_10_years_for_dynamic_date_range branch from 9d7cdc7 to 5ed19c3 Compare April 28, 2025 09:28
@eradman
Copy link
Collaborator

eradman commented May 2, 2025

Adding "Last (3, 5, 7, 10) years" could be even more useful. Of course we don't want to add too many items!
I bet we could get rid of "Last 12 months" since this is very close to "Last year"

Let's see if others have a comment on the this

@yoshiokatsuneo
Copy link
Contributor Author

@eradman

Thank you for your comment !

Adding "Last (3, 5, 7, 10) years" could be even more useful. Of course we don't want to add too many items!

At first, I would like to have a option to select "all range" easily, and "last 10 years" is close to it.

And yes, I think we can add "last 2 years" and "last 3 years" as it is consistent with current "last 1/2/3 months"(last 30/60/90 days) options. How about ?

I bet we could get rid of "Last 12 months" since this is very close to "Last year"

For me, "Last 12 months" is much important as I want to see time series data "up to now" instead of the data "up to a day before new year", normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants