Skip to content

fix algolia search by using promise instead of callback#839

Merged
eradman merged 1 commit intogetredash:masterfrom
yoshiokatsuneo:feat/fix_search
Jul 28, 2025
Merged

fix algolia search by using promise instead of callback#839
eradman merged 1 commit intogetredash:masterfrom
yoshiokatsuneo:feat/fix_search

Conversation

@yoshiokatsuneo
Copy link
Contributor

WHY

#837

On Redash official site knowledge base( redash ), knowledge base search does not work.

HOW

Following the Algolia search API, use promise instead of callback.

References

Test

Manually tested as below.

Before fixing:
image

After fixing:
image

Copy link
Contributor

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works! Thanks @yoshiokatsuneo

@eradman eradman merged commit f179f2c into getredash:master Jul 28, 2025
3 checks passed
@yoshiokatsuneo
Copy link
Contributor Author

@eradman Thank you for the quick review!

@eradman
Copy link
Contributor

eradman commented Aug 1, 2025

I thought changes were automatically deployed, but I don't see this fix on the public web site yet.

@arikfr how are changes published to redash.io?

@arikfr
Copy link
Member

arikfr commented Aug 2, 2025

Netlify supposed to run a deployment everytime there is a merge (and also create a preview for each PR). I will check the config, maybe something is broken.

@arikfr
Copy link
Member

arikfr commented Aug 2, 2025

@eradman @yoshiokatsuneo if you want, I can add you as members to the Netlify project. Send me your email addresses to invite.

@arikfr
Copy link
Member

arikfr commented Aug 2, 2025

@eradman there was an issue similar to the one described here. I clicked "retry without cache" in Netlify's UI and it worked. Hopefully it won't reproduce again on next build.

@yoshiokatsuneo
Copy link
Contributor Author

if you want, I can add you as members to the Netlify project. Send me your email addresses to invite.

@arikfr

Thank you ! And, yes please. My e-mail address is "yoshiokatsuneo@gmail.com".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants