fix algolia search by using promise instead of callback#839
Merged
eradman merged 1 commit intogetredash:masterfrom Jul 28, 2025
Merged
fix algolia search by using promise instead of callback#839eradman merged 1 commit intogetredash:masterfrom
eradman merged 1 commit intogetredash:masterfrom
Conversation
eradman
approved these changes
Jul 28, 2025
Contributor
eradman
left a comment
There was a problem hiding this comment.
This fix works! Thanks @yoshiokatsuneo
Contributor
Author
|
@eradman Thank you for the quick review! |
Contributor
|
I thought changes were automatically deployed, but I don't see this fix on the public web site yet. @arikfr how are changes published to redash.io? |
Member
|
Netlify supposed to run a deployment everytime there is a merge (and also create a preview for each PR). I will check the config, maybe something is broken. |
Member
|
@eradman @yoshiokatsuneo if you want, I can add you as members to the Netlify project. Send me your email addresses to invite. |
Member
Contributor
Author
Thank you ! And, yes please. My e-mail address is "yoshiokatsuneo@gmail.com". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
#837
On Redash official site knowledge base( redash ), knowledge base search does not work.
HOW
Following the Algolia search API, use promise instead of callback.
References
Test
Manually tested as below.
Before fixing:

After fixing:
