Skip to content

impr: Clarify how to retract - #40

Merged
philipphofmann merged 1 commit into
mainfrom
philipphofmann-patch-1
May 9, 2025
Merged

impr: Clarify how to retract#40
philipphofmann merged 1 commit into
mainfrom
philipphofmann-patch-1

Conversation

@philipphofmann

@philipphofmann philipphofmann commented May 9, 2025

Copy link
Copy Markdown
Contributor

Clarify that you must leave a comment only containing retract and nothing else to retract a release.

Related publish PR for updating the tests there getsentry/publish#5533.

Clarify that you must leave a comment only containing retract and nothing else to retract a release.
@philipphofmann
philipphofmann merged commit 605bd5b into main May 9, 2025
@philipphofmann
philipphofmann deleted the philipphofmann-patch-1 branch May 9, 2025 08:48
@asottile-sentry

Copy link
Copy Markdown
Contributor

that's not quite true -- it just has to be #retract on a line by itself

@philipphofmann

Copy link
Copy Markdown
Contributor Author

@asottile-sentry that's what I also thought, but it didn't work here getsentry/publish#5526 (comment).

Screenshot 2025-05-12 at 16 10 08

@asottile-sentry

Copy link
Copy Markdown
Contributor

seems github changed their newline type (it used to be \r\n on all platforms now it is \n) -- should be an easy fix if you'd like to adjust the workflow

@philipphofmann

Copy link
Copy Markdown
Contributor Author

@asottile-sentry, I'm not really familiar with the codebase. Where can I edit the workflow?

@asottile-sentry

Copy link
Copy Markdown
Contributor

in the standard location in the publish repo

@philipphofmann

Copy link
Copy Markdown
Contributor Author

@asottile-sentry is that it getsentry/publish#5587?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants