Skip to content

Multi-arch docker image #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Multi-arch docker image #197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f72e08
Multi-arch docker image
noamcohen97 Jun 26, 2024
01240c5
Update .github/workflows/build.yml
armenzg Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
push:
branches:
- master

env:
# Variables defined in the repository
SENTRY_ORG: ${{ vars.SENTRY_ORG }}
Expand All @@ -16,48 +17,59 @@ jobs:
docker-build:
name: Build & pubish Docker images
runs-on: ubuntu-latest
permissions:
packages: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/packages/learn-github-packages/about-permissions-for-github-packages#about-scopes-and-permissions-for-package-registries

Upload and publish packages to GitHub Packages

👍🏻

strategy:
matrix:
target:
- name: builder
image: action-release-builder-image:latest
- name: app
image: action-release-image:latest
steps:
- name: Checkout repo
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reference: https://github.com/marketplace/actions/docker-setup-qemu


- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/marketplace/actions/docker-setup-buildx


- name: Login to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

# BUILDKIT_INLINE_CACHE creates the image in such a way that you can
# then use --cache-from (think of a remote cache)
# This feature is allowed thanks to using the buildx plugin
#
# There's a COPY command in the builder stage that can easily invalidate the cache
# If you notice, please add more exceptions to .dockerignore since we loose the value
# of using --cache-from on the app stage
- name: Build Docker builder image
run: |
docker buildx build . \
--build-arg BUILDKIT_INLINE_CACHE=1 \
-t ghcr.io/getsentry/action-release-builder-image:latest \
--cache-from ghcr.io/getsentry/action-release-builder-image:latest \
--target builder

- name: Build Docker image
run: |
docker buildx build . \
--build-arg BUILDKIT_INLINE_CACHE=1 \
-t ghcr.io/getsentry/action-release-image:latest \
--cache-from ghcr.io/getsentry/action-release-image:latest \
--target app

- name: Login and publish
run: |
docker login ghcr.io -u $GITHUB_ACTOR --password-stdin <<< ${{ secrets.GITHUB_TOKEN }}
docker push ghcr.io/getsentry/action-release-builder-image:latest
docker push ghcr.io/getsentry/action-release-image:latest
- name: Build and push
uses: docker/build-push-action@v6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/marketplace/actions/build-and-push-docker-images

with:
platforms: linux/amd64,linux/arm64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR we were only building linux/amd64 but after this PR we will also build linux/arm64

push: ${{ github.ref == 'refs/heads/master' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone reading this PR afterwards, we will only push the image when the check runs under the master branch.

tags: ghcr.io/${{ github.repository_owner }}/${{ matrix.target.image }}
cache-from: ghcr.io/${{ github.repository_owner }}/${{ matrix.target.image }}
target: ${{ matrix.target.name }}
build-args: BUILDKIT_INLINE_CACHE=1

# This step creates real Sentry releases for the action itself:
# https://sentry-ecosystem.sentry.io/releases/?project=6576594
- name: Sentry Release
uses: getsentry/action-release@v1
if: vars.SENTRY_ORG != ''
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_LOG_LEVEL: debug
with:
environment: 'production'
ignore_missing: true
ignore_missing: true
Loading