fix: Ensure action's js builds after bumping version in craft-pre-release #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease Craft runs `craft-pre-release.sh` to bump the version in `package.json` but these changes are then not reflected in the checked in `dist/index.js`. We therefor need to rebuild the dist after bumping the version.
mydea
reviewed
Feb 6, 2025
| * **feat(sourcemaps): Add inject option to inject debug ids into source files and sourcemaps** | ||
|
|
||
| A new option to inject [Debug IDs](https://docs.sentry.io/platforms/javascript/sourcemaps/troubleshooting_js/artifact-bundles/) into source files and sourcemaps was added to the action to ensure proper un-minifaction of your stacktraces. We **strongly recommend enabling** this by setting `inject: true` in your action alongside providing a path to sourcemaps. | ||
| ### 1.10.0 |
There was a problem hiding this comment.
l (for a different PR) do we really want to keep this here? 🤔 IMHO this is good enough in a changelog.md / the release itself?
There was a problem hiding this comment.
I've added this to specifically call out new important changes but not all changes. I've seen other big actions do this. Unfortunately, the action marketplace only shows the readme of the repo. I think discoverability of changelogs is pretty bad with this marketplace.
mydea
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Craft runs
craft-pre-release.shto bump the version inpackage.jsonbut these changes are then not reflected in the checked indist/index.js. We therefor need to rebuild the dist after bumping the version.