fix(ci): Move updating docker tag into own job to avoid setting it twice per run: when the builder image is built and when the app image is built #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
force-pushed
the
ab/set-docker-tag-once
branch
4 times, most recently
from
465e2f0 to
5bae549
Compare
…ice per run: when the builder image is built and when the app image is built
andreiborza
force-pushed
the
ab/set-docker-tag-once
branch
from
5bae549 to
f272755
Compare
chargome
approved these changes
Feb 28, 2025
| @@ -84,7 +84,7 @@ runs: | |||
| INPUT_WORKING_DIRECTORY: ${{ inputs.working_directory }} | |||
| INPUT_DISABLE_TELEMETRY: ${{ inputs.disable_telemetry }} | |||
| INPUT_DISABLE_SAFE_DIRECTORY: ${{ inputs.disable_safe_directory }} | |||
| uses: docker://ghcr.io/getsentry/action-release-image:master | |||
| uses: docker://ghcr.io/getsentry/action-release-image:ab-set-docker-tag-once | |||
There was a problem hiding this comment.
Yes, the flow is to always publish and commit an image name that is based on the git branch name. After merging, the workflow will then trigger and change it back to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the CI triggers for master, the action changes the docker tag back from whatever was committed in a branch to
masterand commits and pushes this change back to the master branch.However, because the job is run ist run twice, once for the builder docker image and once for the app docker image, that step was executed twice, trying to commit and push twice.
We only want to do this once, so I extracted this up into its own job that the building job depends on.