dev: add devenv and frozen requirements #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we... want to drop 3.10? i feel like everyone is on 3.11 or newer |
The reason we kept 3.10 around had to do with pypi: |
| @@ -9,3 +9,4 @@ setuptools==70.0.0 | |||
| build==0.8.0 | |||
| wheel==0.42.0 | |||
| freezegun==1.2.2 | |||
| pip-tools | |||
There was a problem hiding this comment.
should version be pinned here?
There was a problem hiding this comment.
version is pinned in the frozen requirements, so not the biggest deal
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 26 26
Lines 2141 2141
=======================================
Hits 2027 2027
Misses 114 114 ☔ View full report in Codecov by Sentry. |
hubertdeng123
approved these changes
May 2, 2025
hubertdeng123
added a commit
that referenced
this pull request
May 2, 2025
This reverts commit b2b4765.
hubertdeng123
added a commit
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds devenv and also frozen requirements
we should think about how we want to standardize on freezing requirements btw cc @bukzor