Skip to content

fix(up): devservices up will not restart supervisor if it is already running #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hubertdeng123
Copy link
Member

This change makes it so that config changes are picked up on devservices up invocations. Edited or new programs will not be automatically be brought up. This means that if a config change goes in for a program that is currently running, the mode with the program must be brought up again. This behavior seems fine for now, and we can add on functionality later on to ensure the same programs running before are brought up again but seems lower priority

@hubertdeng123 hubertdeng123 requested a review from IanWoodard May 31, 2025 00:37
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (f0a06f0) to head (1f8fb91).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          27       27           
  Lines        2359     2359           
=======================================
  Hits         2242     2242           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant