-
-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: add nanobind leak detector #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 75.70% 75.94% +0.24%
==========================================
Files 125 127 +2
Lines 9713 9846 +133
Branches 1096 1105 +9
==========================================
+ Hits 7353 7478 +125
- Misses 1959 1964 +5
- Partials 401 404 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
import sys | ||
|
||
print("DEBUG: About to write to stderr", file=sys.stdout) | ||
print("nanobind: leaked telkins", file=sys.stderr) | ||
print("DEBUG: Just wrote to stderr", file=sys.stdout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be test code that intentionally triggers the nanobind leak detector by printing a fake leak message to stderr. These debug print statements should be removed before merging as they will cause the test to fail with a false positive leak detection. If this was added to verify the detector's functionality, consider moving it to a dedicated test case for the detector itself rather than leaving it in an unrelated test.
import sys | |
print("DEBUG: About to write to stderr", file=sys.stdout) | |
print("nanobind: leaked telkins", file=sys.stderr) | |
print("DEBUG: Just wrote to stderr", file=sys.stdout) | |
import sys |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
No description provided.