Skip to content

feat/icons/android deno langgraph python #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jesse-Box merged 5 commits into from
Oct 1, 2025
Merged

feat/icons/android deno langgraph python #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8485bfa
Modified: Android svg art
Jesse-Box Oct 1, 2025
c2b9bd8
Modified: Deno svg art
Jesse-Box Oct 1, 2025
bf781ea
Modifed: Python svg art
Jesse-Box Oct 1, 2025
b7d6e5a
Added: Langgraph icon
Jesse-Box Oct 1, 2025
15ecb1b
Modified: Android svg art
Jesse-Box Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/platformIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ export const PLATFORM_TO_ICON = {
kotlin: "kotlin",
"kotlin-android": "android",
langchain: "langchain",
langgraph: "langgraph",

@seer-by-sentry seer-by-sentry Bot Oct 1, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The code adds a mapping for the langgraph platform icon, but the corresponding SVG files are missing, which will cause a runtime error when the icon is loaded.

  • Description: A new mapping for langgraph is added to the PLATFORM_TO_ICON object. However, the corresponding SVG files (svg/langgraph.svg and svg_80x80/langgraph.svg) are not included in this change. When the PlatformIcon component attempts to render this icon, or when the preloadIcons() function is called, the dynamic require() call will fail to find the file. This will result in a MODULE_NOT_FOUND error at runtime, causing the application to crash.

  • Suggested fix: Add the missing langgraph.svg files to both the svg/ and svg_80x80/ directories to ensure they can be loaded at runtime by the PlatformIcon component.
    severity: 0.8, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

launchdarkly: "launchdarkly",
linux: "linux",
mono: "mono",
Expand Down
10 changes: 6 additions & 4 deletions svg/android.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 4 additions & 5 deletions svg/deno.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions svg/langgraph.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 18 additions & 5 deletions svg/python.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading