fix(targets): Target parser should accept both x and X#5894
Merged
Conversation
Changes the targets parser to be case insensitive so we handle both `x` and `X` as checked-off. Alternatively, we can make the char-class `[ xX]`. This fixes the issue reported here: getsentry/craft#611 (comment) (second item)
Member
Author
|
cc @stephanie-anderson -- Not sure why your edit got in as a |
Member
Author
|
FYI validated that this is the case by looking at the logs and testing the regexp: https://regex101.com/r/ivTbZM/1 |
Contributor
let's do this just for specificity sake |
Member
Author
|
@asottile-sentry done |
Member
Author
|
We should probably retry the failing release right after merging this as a test (and just fix that half-release) |
Member
#5882 success! |
|
thank you @BYK! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes the targets parser to be case insensitive so we handle both
xandXas checked-off.Alternatively, we can make the char-class[ xX].Alternatively we can make the entire regex case-insensitive.
This fixes the issue reported here: getsentry/craft#611 (comment) (second item)
Related failure: #5882