Skip to content

add sentry-conventions to auto-approve - #6742

Closed
lcian wants to merge 1 commit into
getsentry:mainfrom
lcian:patch-1
Closed

add sentry-conventions to auto-approve#6742
lcian wants to merge 1 commit into
getsentry:mainfrom
lcian:patch-1

Conversation

@lcian

@lcian lcian commented Dec 3, 2025

Copy link
Copy Markdown
Member

This is an internal package and teams other than SDKs will want to release it.

@lcian
lcian requested a review from a team as a code owner December 3, 2025 08:55
@BYK

BYK commented Dec 3, 2025

Copy link
Copy Markdown
Member

Can you please provide more information about why we need auto publishing for this? It looks like this is publishing to npm and PyPI and it's not very clear what the repo is or why were publishing to those places for me to do a risk assessment.

@lcian

lcian commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

This package contains the Sentry semantic conventions for things like span attributes.
Right now we publish to pypi and npm, and this is used in sentry and snuba and as a git dependency in realy.
In the future we're going to start using these packages in the SDKs and publish to more places as we begin to generate code for more platforms.

The reason to set it to auto-publish is that a product team that's in US timezone might want to release this to use a new/updated attribute, and they would need to wait until someone from the SDKs team approves the release (as we're the only ones that have the rights on this I think).

I guess there might be some valid concerns as this is something that will eventually get shipped to customers in the SDKs.
So maybe we can just keep this not on auto publish or we can find a different way.

@BYK

BYK commented Dec 11, 2025

Copy link
Copy Markdown
Member

@lcian approvals are not limited to SDK teams so we can talk about that instead of auto approve. Is that okay?

@BYK

BYK commented Jan 8, 2026

Copy link
Copy Markdown
Member

Closing due to inactivity.

@BYK BYK closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants