Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-approve.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
sparse-checkout-cone-mode: false
- name: Get auth token
id: token
uses: actions/create-github-app-token@v2.2.1
uses: actions/create-github-app-token@v3
with:
app-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
private-key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-pending.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
- name: Get auth token
id: token
uses: actions/create-github-app-token@v2.2.1
uses: actions/create-github-app-token@v3
with:
app-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
private-key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-poller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
steps:
- name: Get auth token
id: token
uses: actions/create-github-app-token@v2.2.1
uses: actions/create-github-app-token@v3
with:
app-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
private-key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:

- name: Get Release Bot auth token
id: token
uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2
uses: actions/create-github-app-token@v3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA-pinned action replaced with floating major tag

Low Severity

The create-github-app-token action in publish.yml was previously pinned to a specific commit SHA (@29824e69...), which protects against supply-chain attacks by ensuring the exact code is known and immutable. It's now changed to a floating major version tag (@v3), which can be moved to point to different code at any time. This workflow runs in the production environment and has access to many sensitive secrets (NPM tokens, Docker credentials, GPG keys, PyPI tokens, etc.), so the original SHA pinning was presumably a deliberate security measure. The other three workflow files were already using floating tags, but publish.yml has a significantly higher blast radius.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 52727ee. Configure here.

with:
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}
Expand Down
Loading