Skip to content

fix(workflow): handle monorepo paths in title parsing and fix app-id deprecation#7779

Merged
BYK merged 1 commit into
mainfrom
fix/ci-poller-monorepo-and-deprecations
Apr 13, 2026
Merged

fix(workflow): handle monorepo paths in title parsing and fix app-id deprecation#7779
BYK merged 1 commit into
mainfrom
fix/ci-poller-monorepo-and-deprecations

Conversation

@BYK

@BYK BYK commented Apr 13, 2026

Copy link
Copy Markdown
Member

Summary

Two fixes:

1. Monorepo title parsing (causes CI poller to 404)

The repo parser extracted the full path from monorepo issue titles, e.g., publish: getsentry/relay/py@0.9.26getsentry/relay/py. API calls to repos/getsentry/relay/py/... returned 404, so the poller could never detect CI completion.

Fix: only extract owner/repo (first two path segments). getsentry/relay/pygetsentry/relay.

Failing run: https://github.com/getsentry/publish/actions/runs/24335600870/job/71053497008

2. Deprecated app-id input

Replace app-id with client-id on actions/create-github-app-token@v3 across all workflow files.

Re: irregular cron timing

GitHub Actions cron is not guaranteed to run on time — from the docs: "The schedule event can be delayed during periods of high loads." This is expected behavior and not something we can fix.

…deprecation

Two fixes:

1. The repo parser grabbed the full path (e.g., "getsentry/relay/py")
   from monorepo titles like "publish: getsentry/relay/py@0.9.26",
   causing 404s on the GitHub API. Now only extracts owner/repo (first
   two segments): "getsentry/relay".

2. Replace deprecated app-id input with client-id on
   create-github-app-token@v3 across all workflow files.
@BYK BYK marked this pull request as ready for review April 13, 2026 09:39
@BYK BYK requested a review from a team as a code owner April 13, 2026 09:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 46ac503. Configure here.

uses: actions/create-github-app-token@v3
with:
app-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
client-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client-id is not a valid input for this action

High Severity

actions/create-github-app-token@v3 does not accept client-id as an input — the required input is still named app-id. The rename was requested in the action's issue #252 but never implemented. The unknown client-id input will be silently ignored, leaving the required app-id unset, which will cause the token step to fail in all four workflows (auto-approve.yml, ci-pending.yml, ci-poller.yml, publish.yml). This breaks authentication for auto-approval, CI label management, CI polling, and publishing.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 46ac503. Configure here.

@BYK BYK merged commit 01193fa into main Apr 13, 2026
10 checks passed
@BYK BYK deleted the fix/ci-poller-monorepo-and-deprecations branch April 13, 2026 09:58
jpnurmi added a commit to getsentry/sentry-desktop-crash-reporter that referenced this pull request Apr 21, 2026
The app-id input was deprecated in v3.1.0 in favor of client-id.
Mirrors getsentry/publish#7779.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant