Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relay): do not assume empty means {{auto}} for some sdks #4519

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Feb 24, 2025

This PR introduces a cut-off version after which an empty string will not be translated to {{auto}} for Javascript and Cocoa/Objc platforms.

Turning on the toggle in Sentry will inject rules to scrub IP addresses, so we don't have to touch the code that derives {{auto}} to the IP itself.
If we have concerns with the approach we can also check in the code that derives the IP.

Cocoa sends {{auto}} starting with 6.2.0.
Javascript sends {{auto}} starting with 9.0.0.
Obj-C SDK is deprecated so we keep the old behaviour as there will never be a new version.

@Litarnus Litarnus self-assigned this Feb 24, 2025
@Litarnus Litarnus marked this pull request as ready for review February 24, 2025 16:06
@Litarnus Litarnus requested a review from a team as a code owner February 24, 2025 16:06
@Litarnus Litarnus requested a review from HazAT February 25, 2025 08:38
@Litarnus Litarnus linked an issue Feb 25, 2025 that may be closed by this pull request
@cleptric
Copy link
Member

cleptric commented Mar 3, 2025

Instead of making this decision based on the platform, we need to use sdk.name.
I compiled a list of all relevant SDKs and the minimum version where Relay should no longer infer the IP by default.

# JS FE
sentry.javascript.angular -> v9.0.0
sentry.javascript.angular-ivy -> v9.0.0
sentry.javascript.astro -> v9.0.0
sentry.javascript.browser -> v9.0.0
sentry.javascript.ember -> v9.0.0
sentry.javascript.gatsby -> v9.0.0
sentry.javascript.nextjs -> v9.0.0
sentry.javascript.nuxt -> v9.0.0
sentry.javascript.react -> v9.0.0
sentry.javascript.react-router -> v9.0.0
sentry.javascript.remix -> v9.0.0
sentry.javascript.solid -> v9.0.0
sentry.javascript.solidstart -> v9.0.0
sentry.javascript.svelte -> v9.0.0
sentry.javascript.sveltekit -> v9.0.0
sentry.javascript.tanstackstart -> v9.0.0
sentry.javascript.vue -> v9.0.0
sentry.javascript.wasm -> v9.0.0

# Mobile
sentry.javascript.react-native -> v7.0.0
sentry.cocoa.react-native -> v8.47.0 **TBD**

sentry.javascript.capacitor -> v2.0.0
sentry.cocoa.capacitor -> v8.47.0 **TBD**

# Others
sentry.javascript.electron -> v6.0.0

@kahest
Copy link
Member

kahest commented Mar 5, 2025

We are adding a note to sentry-cocoa changelog that this behavior changes with version 8.47.0 of the SDK -> getsentry/sentry-cocoa#4945

@Dav1dde
Copy link
Member

Dav1dde commented Mar 5, 2025

@kahest we're still evaluating options and thinking of alternate solutions.

@cleptric did a small writeup here.

So maybe not yet ready for a changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not derive {{auto}} IPs when toggle is off
5 participants