-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relay): do not assume empty means {{auto}} for some sdks #4519
Open
Litarnus
wants to merge
13
commits into
master
Choose a base branch
from
martinl/empty-ip-not-auto
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Feb 25, 2025
Dav1dde
approved these changes
Feb 25, 2025
Instead of making this decision based on the
|
We are adding a note to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a cut-off version after which an empty string will not be translated to
{{auto}}
for Javascript and Cocoa/Objc platforms.Turning on the toggle in Sentry will inject rules to scrub IP addresses, so we don't have to touch the code that derives
{{auto}}
to the IP itself.If we have concerns with the approach we can also check in the code that derives the IP.
Cocoa sends
{{auto}}
starting with 6.2.0.Javascript sends
{{auto}}
starting with 9.0.0.Obj-C SDK is deprecated so we keep the old behaviour as there will never be a new version.