Add a waitForFullDisplay parameter to the sentryTrace() SwiftUI modifier

[matthewreimer]

Problem Statement

For control and for symmetry with SentryTracedView it would be nice for the sentryTrace() SwiftUI view modifier to have a waitForFullDisplay parameter.

Solution Brainstorm

Basically this:

--- SentryTracedView.swift.orig	2025-02-03 10:10:26
+++ SentryTracedView.swift	2025-02-03 10:10:57
@@ -1,7 +1,7 @@
 @available(iOS 13, macOS 10.15, tvOS 13, watchOS 6.0, *)
 public extension View {
-    func sentryTrace(_ viewName: String? = nil) -> some View {
-        return SentryTracedView(viewName) {
+    func sentryTrace(_ viewName: String? = nil, waitForFullDisplay: Bool? = nil) -> some View {
+        return SentryTracedView(viewName, waitForFullDisplay: waitForFullDisplay) {
             return self
         }
     }

Are you willing to submit a PR?

Yes

[kahest]

This should be covered in https://github.com/getsentry/sentry-cocoa/pull/4596/files :)
Please note that work on the feature #4162 is still in progress.

Closing this, feel free to comment if I misunderstood, or follow up on the other issue

[kahest]

I realize I misread - this is requesting waitForFullDisplay for sentryTrace. Before I reopen, can you @matthewreimer clarify what your use case is for this, other than symmetry?

[matthewreimer]

@kahest Our use case is that in order to keep our code easier to read, we use .sentryTrace() instead of SentryTracedView(), because we can tuck .sentryTrace("ourviewname") down near the end of the view body rather than it having to be right at the top of the view body. Also, doing so reduces the indentation level a bit.

In other words, instead of this:

SentryTracedView("My Awesome Screen") {
    VStack {
        // The part of your content you want to measure
    }
}

we prefer to do this:

VStack {
    // The part of your content you want to measure
    // This makes the substance of the view more prominent than if it's nested
}
.sentryTrace("some view name")

[kahest]

@matthewreimer got it, we'll discuss if we can add this

[philprime]

@matthewreimer after discussing this internally, we believe your solution brainstorm should work. Can you please open up a PR with the proposed changes? We are happy to review it.

[matthewreimer]

@philprime Here you go: #4797