Skip to content

feat: add waitForFullDisplay to sentryTrace view modifier #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

matthewreimer
Copy link
Contributor

@matthewreimer matthewreimer commented Feb 5, 2025

Add a waitForFullDisplay parameter to the sentryTrace view modifier on platforms that support it, for parity with SentryTracedView.

📜 Description

Add a waitForFullDisplay parameter to the sentryTrace view modifier on platforms that support it

💡 Motivation and Context

SentryTracedView has a waitForFullDisplay parameter on platforms that support it, but not the alternative sentryTrace view modifier. Adding this parameter gives the view modifier parity with the View.

Fixes #4787.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add a waitForFullDisplay parameter to the sentryTrace view modifier
on platforms that support it, for parity with SentryTracedView.

Fixes getsentry#4787.
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for creating the PR

@philprime
Copy link
Contributor

Sorry for the additional pings, for some reason the changelog got formatted and the revert wasn't applied.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.303%. Comparing base (01ea3df) to head (5de7cab).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4797       +/-   ##
=============================================
- Coverage   91.320%   91.303%   -0.018%     
=============================================
  Files          627       627               
  Lines        74570     74568        -2     
  Branches     26186     26177        -9     
=============================================
- Hits         68098     68083       -15     
- Misses        6380      6390       +10     
- Partials        92        95        +3     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ea3df...5de7cab. Read the comment docs.

@philprime philprime self-assigned this Feb 6, 2025
@philprime philprime merged commit bdd896e into getsentry:main Feb 6, 2025
67 of 74 checks passed
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewreimer 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a waitForFullDisplay parameter to the sentryTrace() SwiftUI modifier
3 participants