test(profiling): fix broken tests for new APi

[armcknight]

In #4856 (comment), I changed the code incorrectly from using an assert to just a conditional check, causing some test failures. This fixes that, along with some cosmetic improvements to the tests.

#skip-changelog; for #4853

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1229.49 ms	1251.51 ms	22.02 ms
Size	22.30 KiB	840.35 KiB	818.05 KiB

Baseline results on branch: armcknight/profiling/new-continuous-apis/reevaluate-sample-rate-on-fg

Startup times

Revision	Plain	With Sentry	Diff
b0669f6	1214.56 ms	1236.65 ms	22.09 ms
c08096f	1225.00 ms	1244.76 ms	19.76 ms
bea2645	1225.67 ms	1245.24 ms	19.57 ms

App size

Revision	Plain	With Sentry	Diff
b0669f6	22.30 KiB	840.39 KiB	818.08 KiB
c08096f	22.30 KiB	840.29 KiB	817.98 KiB
bea2645	22.30 KiB	840.39 KiB	818.08 KiB

Previous results on branch: armcknight/profiling/new-continuous-apis/fix-tests

Startup times

Revision	Plain	With Sentry	Diff
04c4506	1217.71 ms	1238.71 ms	21.00 ms
11c6e34	1243.69 ms	1265.94 ms	22.24 ms
8b80933	1223.00 ms	1243.96 ms	20.96 ms

App size

Revision	Plain	With Sentry	Diff
04c4506	22.30 KiB	840.42 KiB	818.12 KiB
11c6e34	22.30 KiB	840.42 KiB	818.11 KiB
8b80933	22.30 KiB	840.42 KiB	818.12 KiB

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (armcknight/profiling/new-continuous-apis/reevaluate-sample-rate-on-fg@b4e1070). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...entry/Profiling/SentryProfiledTracerConcurrency.mm	71.428%	2 Missing ⚠️

Additional details and impacted files

@@                                            Coverage Diff                                            @@
##             armcknight/profiling/new-continuous-apis/reevaluate-sample-rate-on-fg     #4998   +/-   ##
=========================================================================================================
  Coverage                                                                         ?   92.743%           
=========================================================================================================
  Files                                                                            ?       673           
  Lines                                                                            ?     82716           
  Branches                                                                         ?     30019           
=========================================================================================================
  Hits                                                                             ?     76714           
  Misses                                                                           ?      5903           
  Partials                                                                         ?        99           

Files with missing lines	Coverage Δ
...yProfilerTests/SentryProfilingPublicAPITests.swift	98.564% <100.000%> (ø)
...entry/Profiling/SentryProfiledTracerConcurrency.mm	94.230% <71.428%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e1070...2482631. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[philprime]

LGTM