-
-
Notifications
You must be signed in to change notification settings - Fork 365
Convert SentryScreenFrames
to Swift
#6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6094 +/- ##
========================================
Coverage ? 86.783%
========================================
Files ? 438
Lines ? 37197
Branches ? 17391
========================================
Hits ? 32281
Misses ? 4874
Partials ? 42
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be9107c | 1223.63 ms | 1242.82 ms | 19.19 ms |
b193842 | 1231.36 ms | 1247.69 ms | 16.33 ms |
884b224 | 1221.11 ms | 1255.88 ms | 34.77 ms |
3279d4e | 1215.76 ms | 1256.45 ms | 40.69 ms |
ccf1278 | 1226.84 ms | 1248.51 ms | 21.67 ms |
f2bfecd | 1234.92 ms | 1250.34 ms | 15.42 ms |
52603c5 | 1229.35 ms | 1251.82 ms | 22.47 ms |
8fd192f | 1202.10 ms | 1220.19 ms | 18.09 ms |
d06a4db | 1233.20 ms | 1243.18 ms | 9.98 ms |
f43a482 | 1219.00 ms | 1245.56 ms | 26.56 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be9107c | 23.75 KiB | 975.19 KiB | 951.44 KiB |
b193842 | 23.75 KiB | 920.65 KiB | 896.90 KiB |
884b224 | 23.75 KiB | 879.55 KiB | 855.80 KiB |
3279d4e | 23.75 KiB | 938.32 KiB | 914.57 KiB |
ccf1278 | 23.75 KiB | 877.15 KiB | 853.40 KiB |
f2bfecd | 23.75 KiB | 919.68 KiB | 895.93 KiB |
52603c5 | 23.75 KiB | 969.66 KiB | 945.92 KiB |
8fd192f | 23.74 KiB | 872.75 KiB | 849.01 KiB |
d06a4db | 23.75 KiB | 913.18 KiB | 889.43 KiB |
f43a482 | 23.75 KiB | 928.16 KiB | 904.41 KiB |
Previous results on branch: itay/cocoa-547-convert-sentryscreenframes-to-swift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
387a2ac | 1202.26 ms | 1235.83 ms | 33.58 ms |
cd01c20 | 1225.64 ms | 1245.30 ms | 19.66 ms |
ce9aaeb | 1218.53 ms | 1247.19 ms | 28.66 ms |
39c2e42 | 1225.44 ms | 1251.08 ms | 25.64 ms |
5f7ee5f | 1235.24 ms | 1254.13 ms | 18.88 ms |
2e6b4be | 1216.04 ms | 1256.43 ms | 40.39 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
387a2ac | 23.75 KiB | 964.28 KiB | 940.53 KiB |
cd01c20 | 23.74 KiB | 972.09 KiB | 948.35 KiB |
ce9aaeb | 23.75 KiB | 974.48 KiB | 950.73 KiB |
39c2e42 | 23.74 KiB | 978.66 KiB | 954.92 KiB |
5f7ee5f | 23.75 KiB | 966.10 KiB | 942.35 KiB |
2e6b4be | 23.75 KiB | 963.56 KiB | 939.82 KiB |
Waiting for RN integration fix here: getsentry/sentry-react-native#5153 |
…coa-547-convert-sentryscreenframes-to-swift
#skip-changelog
Closes #6119