Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Sep 5, 2025

#skip-changelog

Closes #6119

Copy link

linear bot commented Sep 5, 2025

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3b059e5). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6094   +/-   ##
========================================
  Coverage        ?   86.783%           
========================================
  Files           ?       438           
  Lines           ?     37197           
  Branches        ?     17391           
========================================
  Hits            ?     32281           
  Misses          ?      4874           
  Partials        ?        42           
Files with missing lines Coverage Δ
SentryTestUtils/TestFramesTracker.swift 100.000% <100.000%> (ø)
...urces/Sentry/Profiling/SentryContinuousProfiler.mm 90.344% <100.000%> (ø)
...entry/Profiling/SentryProfiledTracerConcurrency.mm 91.439% <100.000%> (ø)
...ntry/Profiling/SentryProfilingScreenFramesHelper.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryFramesTracker.m 100.000% <ø> (ø)
Sources/Sentry/SentryProfiler.mm 91.011% <ø> (ø)
Sources/Sentry/SentrySpan.m 97.701% <ø> (ø)
Sources/Sentry/SentryTracer.m 97.540% <ø> (ø)
...tegrations/FramesTracking/SentryScreenFrames.swift 100.000% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b059e5...9ef599d. Read the comment docs.

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.78 ms 1257.64 ms 21.86 ms
Size 23.75 KiB 983.34 KiB 959.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
be9107c 1223.63 ms 1242.82 ms 19.19 ms
b193842 1231.36 ms 1247.69 ms 16.33 ms
884b224 1221.11 ms 1255.88 ms 34.77 ms
3279d4e 1215.76 ms 1256.45 ms 40.69 ms
ccf1278 1226.84 ms 1248.51 ms 21.67 ms
f2bfecd 1234.92 ms 1250.34 ms 15.42 ms
52603c5 1229.35 ms 1251.82 ms 22.47 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
d06a4db 1233.20 ms 1243.18 ms 9.98 ms
f43a482 1219.00 ms 1245.56 ms 26.56 ms

App size

Revision Plain With Sentry Diff
be9107c 23.75 KiB 975.19 KiB 951.44 KiB
b193842 23.75 KiB 920.65 KiB 896.90 KiB
884b224 23.75 KiB 879.55 KiB 855.80 KiB
3279d4e 23.75 KiB 938.32 KiB 914.57 KiB
ccf1278 23.75 KiB 877.15 KiB 853.40 KiB
f2bfecd 23.75 KiB 919.68 KiB 895.93 KiB
52603c5 23.75 KiB 969.66 KiB 945.92 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
d06a4db 23.75 KiB 913.18 KiB 889.43 KiB
f43a482 23.75 KiB 928.16 KiB 904.41 KiB

Previous results on branch: itay/cocoa-547-convert-sentryscreenframes-to-swift

Startup times

Revision Plain With Sentry Diff
387a2ac 1202.26 ms 1235.83 ms 33.58 ms
cd01c20 1225.64 ms 1245.30 ms 19.66 ms
ce9aaeb 1218.53 ms 1247.19 ms 28.66 ms
39c2e42 1225.44 ms 1251.08 ms 25.64 ms
5f7ee5f 1235.24 ms 1254.13 ms 18.88 ms
2e6b4be 1216.04 ms 1256.43 ms 40.39 ms

App size

Revision Plain With Sentry Diff
387a2ac 23.75 KiB 964.28 KiB 940.53 KiB
cd01c20 23.74 KiB 972.09 KiB 948.35 KiB
ce9aaeb 23.75 KiB 974.48 KiB 950.73 KiB
39c2e42 23.74 KiB 978.66 KiB 954.92 KiB
5f7ee5f 23.75 KiB 966.10 KiB 942.35 KiB
2e6b4be 23.75 KiB 963.56 KiB 939.82 KiB

@itaybre
Copy link
Contributor Author

itaybre commented Sep 8, 2025

Waiting for RN integration fix here: getsentry/sentry-react-native#5153

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert SentryScreenFrames to Swift
2 participants