Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Sep 11, 2025

Converts SentryViewHierarchyProvider to Swift

#skip-changelog

Closes #6158

Copy link

codecov bot commented Sep 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3934 1 3933 52
View the top 2 failed test(s) by shortest run time
SentryTests.SentryNetworkTrackerIntegrationTests::testGetRequest_SpanCreatedAndBaggageHeaderAdded
Stack Traces | 0s run time
.../Performance/Network/SentryNetworkTrackerIntegrationTests.swift:176 - Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Request completed".
iOS_Swift_UITests.UserFeedbackUITests::testAddingScreenshots
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:670 - XCTUnwrap failed: expected non-nil value of type "String"

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

github-actions bot commented Sep 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.77 ms 1265.35 ms 29.58 ms
Size 23.75 KiB 980.05 KiB 956.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
be8375a 1212.65 ms 1239.72 ms 27.08 ms
f5666e7 1227.08 ms 1260.18 ms 33.10 ms
3133d0e 1237.86 ms 1262.87 ms 25.01 ms
588dd7c 1235.11 ms 1241.76 ms 6.65 ms
48e5c8a 1223.02 ms 1242.38 ms 19.35 ms
18be519 1241.22 ms 1260.57 ms 19.35 ms
effeafa 1225.88 ms 1249.78 ms 23.90 ms
e3ebff3 1223.47 ms 1249.27 ms 25.80 ms
5cfc768 1220.74 ms 1245.06 ms 24.32 ms
61414e8 1225.49 ms 1254.28 ms 28.79 ms

App size

Revision Plain With Sentry Diff
be8375a 23.75 KiB 933.03 KiB 909.28 KiB
f5666e7 23.75 KiB 963.18 KiB 939.43 KiB
3133d0e 23.74 KiB 976.79 KiB 953.04 KiB
588dd7c 23.75 KiB 938.33 KiB 914.58 KiB
48e5c8a 23.75 KiB 913.63 KiB 889.88 KiB
18be519 23.75 KiB 926.64 KiB 902.90 KiB
effeafa 23.74 KiB 926.64 KiB 902.89 KiB
e3ebff3 23.75 KiB 878.48 KiB 854.73 KiB
5cfc768 23.75 KiB 850.73 KiB 826.98 KiB
61414e8 23.75 KiB 867.69 KiB 843.94 KiB

Previous results on branch: viewHierarchySwift

Startup times

Revision Plain With Sentry Diff
0ecc502 1228.17 ms 1260.60 ms 32.43 ms
ebfd1a0 1235.06 ms 1253.19 ms 18.13 ms
025f72e 1208.65 ms 1233.69 ms 25.04 ms
701652c 1231.52 ms 1254.45 ms 22.93 ms
7d3181a 1220.55 ms 1253.02 ms 32.47 ms
05ec4e5 1213.82 ms 1235.57 ms 21.76 ms

App size

Revision Plain With Sentry Diff
0ecc502 23.74 KiB 972.96 KiB 949.22 KiB
ebfd1a0 23.74 KiB 971.03 KiB 947.28 KiB
025f72e 23.74 KiB 972.96 KiB 949.21 KiB
701652c 23.74 KiB 972.96 KiB 949.22 KiB
7d3181a 23.75 KiB 971.21 KiB 947.46 KiB
05ec4e5 23.75 KiB 972.95 KiB 949.21 KiB

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, almost LGTM

@noahsmartin
Copy link
Contributor Author

Thanks @philprime this is ready for a second look whenever you get a chance

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin merged commit bc4bb46 into main Sep 23, 2025
232 of 250 checks passed
@noahsmartin noahsmartin deleted the viewHierarchySwift branch September 23, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref: Convert SentryViewHierarchyProvider to Swift
2 participants