Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 28, 2025

Renames the Carthage validation project which uses xcframeworks to just XCFramework Validation project

Cleanups some script that wont be used anymore too.

Follows #6926 in removing Carthage references.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.071%. Comparing base (532f33c) to head (f50c097).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (532f33c) and HEAD (f50c097). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (532f33c) HEAD (f50c097)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6931        +/-   ##
=============================================
- Coverage   84.913%   7.071%   -77.842%     
=============================================
  Files          453      418        -35     
  Lines        27628    26372      -1256     
  Branches     12133     9897      -2236     
=============================================
- Hits         23460     1865     -21595     
- Misses        4123    24494     +20371     
+ Partials        45       13        -32     

see 439 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532f33c...f50c097. Read the comment docs.

@itaybre itaybre marked this pull request as ready for review November 28, 2025 19:42
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.37 ms 1246.24 ms 23.88 ms
Size 24.14 KiB 1.01 MiB 1015.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0ee162c 1226.90 ms 1261.72 ms 34.83 ms
7f26f16 1220.62 ms 1255.04 ms 34.42 ms
5290541 1216.38 ms 1249.56 ms 33.18 ms
319fb1e 1219.48 ms 1242.69 ms 23.21 ms
0f410ad 1193.34 ms 1255.49 ms 62.15 ms
b6f8eb3 1217.94 ms 1246.57 ms 28.63 ms
e8f9a1d 1229.02 ms 1264.17 ms 35.15 ms
37238de 1236.00 ms 1267.80 ms 31.80 ms
0ecea77 1191.47 ms 1216.12 ms 24.65 ms
1655116 1220.72 ms 1260.58 ms 39.85 ms

App size

Revision Plain With Sentry Diff
0ee162c 23.75 KiB 933.33 KiB 909.58 KiB
7f26f16 23.75 KiB 1.02 MiB 1016.66 KiB
5290541 24.14 KiB 1.01 MiB 1015.38 KiB
319fb1e 23.75 KiB 1019.18 KiB 995.43 KiB
0f410ad 24.14 KiB 1.01 MiB 1014.82 KiB
b6f8eb3 23.75 KiB 988.70 KiB 964.95 KiB
e8f9a1d 23.75 KiB 969.78 KiB 946.04 KiB
37238de 23.75 KiB 963.18 KiB 939.43 KiB
0ecea77 24.15 KiB 1.01 MiB 1014.90 KiB
1655116 23.75 KiB 1023.84 KiB 1000.10 KiB

@@ -1 +0,0 @@
brew 'carthage'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to delete this file now


/* Begin PBXFileReference section */
1573CAE22BBCA4820018A2B7 /* SentrySwiftUI.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = SentrySwiftUI.xcframework; path = Carthage/Build/SentrySwiftUI.xcframework; sourceTree = "<group>"; };
1573CAE22BBCA4820018A2B7 /* SentrySwiftUI.xcframework */ = {isa = PBXFileReference; expectedSignature = "AppleDeveloperProgram:97JCY7859U:GetSentry LLC"; lastKnownFileType = wrapper.xcframework; name = SentrySwiftUI.xcframework; path = ../../Carthage/SentrySwiftUI.xcframework; sourceTree = "<group>"; };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm, I wonder if having the expected signature may bite us in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants