Skip to content

impr: remove mergeable-library metadata from dynamic xcframework #8658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
itaybre wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −6
Draft

impr: remove mergeable-library metadata from dynamic xcframework #8658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536d5da
impr: remove mergeable-library metadata from dynamic xcframework
itaybre Aug 3, 2026
6f3e930
fix: use PR number in changelog entry
itaybre Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@

- Add `SentrySDK.feedback.enableOnShake()` and `disableOnShake()` to toggle the shake-to-report gesture at runtime (#8591)

### Improvements

- Reduce Sentry-Dynamic.xcframework binary size by ~7.6 MB per arm64 slice by removing unused mergeable-library metadata (LC_ATOM_INFO) (#8658)

### Fixes

- Fix incorrect `duration` sent for active sessions (#8612)
Expand Down
6 changes: 0 additions & 6 deletions scripts/build-xcframework-slice.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,6 @@ fi

rm -rf XCFrameworkBuildPath/DerivedData

@philprime philprime Aug 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: I understand that SPM is not supporting mergeable libraries, but these Xcode Frameworks are also consumed directly downloaded from GitHub Releases. Is this change going to break customer build scripts?

@itaybre itaybre Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is downloading the xcframework with the intention of using it as a mergeable library, this would be a breaking change. I don't think we have any way to measure how many users are doing this.

We can wait until v10 if you believe there are users using it as mergeable

@philprime philprime Aug 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be best-practice to do so.

## watchos and watchsimulator don't support make_mergeable: ld: unknown option: -make_mergeable
## For other dynamic frameworks, add -make_mergeable (append to existing flags)
if [[ "$sdk" != "watchos" && "$sdk" != "watchsimulator" ]] && [ "$MACH_O_TYPE" != "staticlib" ]; then
OTHER_LDFLAGS="$OTHER_LDFLAGS -Wl,-make_mergeable"
fi

slice_id="${scheme}${suffix}-${sdk}"

output_xcarchive_path="XCFrameworkBuildPath/archive/${scheme}${suffix}"
Expand Down
Loading