test: warn on clearTestState() usage via SwiftLint - #8706
Merged
Conversation
Add a warning-level custom rule flagging clearTestState() call sites so new usages get a second look. Existing call sites are suppressed with a note to reconsider if touched.
philipphofmann
added
the
run-full-ci
philipphofmann
marked this pull request as ready for review
August 6, 2026 12:04
philipphofmann
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philprime
as code owners
August 6, 2026 12:04
philipphofmann
enabled auto-merge (squash)
August 6, 2026 12:39
NinjaLikesCheez
disabled auto-merge
August 7, 2026 09:01
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 589c2ae. Configure here.
itaybre
pushed a commit
that referenced
this pull request
Aug 7, 2026
* test: warn on clearTestState() usage via SwiftLint Add a warning-level custom rule flagging clearTestState() call sites so new usages get a second look. Existing call sites are suppressed with a note to reconsider if touched. * test: reword clearTestState() lint suppression note * test: suppress avoid_clear_test_state in NetworkTrackerIntegrationTestServerTests --------- Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
itaybre
added a commit
that referenced
this pull request
Aug 7, 2026
* feat: enable swiftAsyncStacktraces by default in v10 The feature was marked stable in v9.22.0. Enabling by default gives users stitched async stack traces out of the box. This impacts grouping, so it's gated to the major version. * chore: update changelog PR reference * fix: update LoadValidator error message (#8710) * perf(session-replay): Prefer in-memory frames for live encode (#8636) * perf(session-replay): Prefer in-memory frames for live encode Keep scaled UIImages for live video encode while still writing PNGs to disk for crash durability. Encode falls back to disk only for frames recovered after a crash, avoiding PNG readback on the streaming path. Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io> * meta: Link changelog entry to #8636 Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io> * ref(session-replay): Keep frame image loading off the data struct Move disk fallback out of SentryReplayFrame into image(for:) so the frame type stays a pure value without file I/O. * ref(session-replay): Load frame images through file manager Co-Authored-By: Phil Niedertscheider <phil.niedertscheider@sentry.io> * ci: Retrigger flaky full CI jobs Re-run after unrelated visionOS timeout, UI runner flake, and cancelled tvOS unit job on the previous head. Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io> Co-Authored-By: Itay Brenner <itay.brenner@sentry.io> Co-Authored-By: Phil Niedertscheider <phil.niedertscheider@sentry.io> * Update CHANGELOG with new features and improvements Added experimental option for UIViewController swizzling and improved Session Replay memory management. * ref(session-replay): Inline image(atPath:) static method Remove the thin static wrapper and use UIImage(contentsOfFile:) directly at call sites. Keep the original variable name in SentryVideoFrameProcessor to minimize diff. * ref(session-replay): Keep original variable name in OnDemandReplay --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io> Co-authored-by: Phil Niedertscheider <phil.niedertscheider@sentry.io> Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> * test: warn on clearTestState() usage via SwiftLint (#8706) * test: warn on clearTestState() usage via SwiftLint Add a warning-level custom rule flagging clearTestState() call sites so new usages get a second look. Existing call sites are suppressed with a note to reconsider if touched. * test: reword clearTestState() lint suppression note * test: suppress avoid_clear_test_state in NetworkTrackerIntegrationTestServerTests --------- Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com> * fix: stamp sentry-cocoa version in 3rd-party archives (#8699) * fix: stamp sentry-cocoa version in 3rd-party archives The 3rd-party integration archives were built before Craft bumped the version, so the tagged Package.swift contained the previous release's sentry-cocoa dependency. * test: assert version stamp in archive CI * fix: improve tar command in create_tgz_from_staging function Updated the tar command in the create_tgz_from_staging function to use tr for newline handling, ensuring compatibility with file names containing special characters. This change enhances the robustness of the archive creation process. * feat: enable logging by default in v10 (#8717) * feat: enable logging by default in v10 The logging spec v2.0.0 requires enableLogs to default to true. No logs are emitted unless the user explicitly calls SentrySDK.logger or enables a logging integration. * chore: update changelog PR reference * feat: enable swiftAsyncStacktraces by default in v10 The feature was marked stable in v9.22.0. Enabling by default gives users stitched async stack traces out of the box. This impacts grouping, so it's gated to the major version. * chore: update changelog PR reference * test: update default features for v10 async stacktraces Include swiftAsyncStacktraces in testDefaultFeatures expected list under SDK_V10, matching the new default. * chore: remove duplicate changelog entry * test: expect SwiftAsync integration in v10 tests --------- Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io> Co-authored-by: Phil Niedertscheider <phil.niedertscheider@sentry.io> Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com> Co-authored-by: Philipp Süß <philipp.hofmann@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I can stop pointing that out in PRs.
#skip-changelog
Closes #8707