fix: Forward device option in UI critical test lanes - #8709
Merged
Conversation
The ui_critical_tests_ios_swiftui_envelope and ui_critical_tests_ios_swiftui_all lanes were missing the options block parameter, silently ignoring the device passed by CI. This caused Fastlane to pick an arbitrary simulator (iPhone 14 Pro on iOS 16.4) instead of the intended target (iPhone 16 Pro on iOS 18.5), leading to flaky "Test runner never began executing tests" failures.
itaybre
added
the
run-full-ci
itaybre
marked this pull request as ready for review
August 6, 2026 15:06
itaybre
requested review from
NinjaLikesCheez,
noahsmartin,
philipphofmann and
philprime
as code owners
August 6, 2026 15:06
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 59213ba | 1223.66 ms | 1258.02 ms | 34.36 ms |
| 23b642a | 1235.62 ms | 1270.53 ms | 34.92 ms |
| 70e2dea | 1219.63 ms | 1251.72 ms | 32.09 ms |
| 9c0db16 | 1219.04 ms | 1247.83 ms | 28.78 ms |
| 4da7fcb | 1209.38 ms | 1251.78 ms | 42.40 ms |
| a250b4d | 1217.19 ms | 1250.80 ms | 33.62 ms |
| 75d7de0 | 1217.24 ms | 1251.27 ms | 34.03 ms |
| 49cc12d | 1227.33 ms | 1263.21 ms | 35.89 ms |
| 00009c7 | 1231.69 ms | 1265.73 ms | 34.04 ms |
| c1c9578 | 1219.32 ms | 1261.74 ms | 42.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 59213ba | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 23b642a | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| 70e2dea | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| 9c0db16 | 24.14 KiB | 1.19 MiB | 1.17 MiB |
| 4da7fcb | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| a250b4d | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 75d7de0 | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| 49cc12d | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| 00009c7 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| c1c9578 | 24.14 KiB | 1.20 MiB | 1.18 MiB |
philprime
approved these changes
Aug 6, 2026
itaybre
enabled auto-merge (squash)
August 6, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ui_critical_tests_ios_swiftui_envelopeandui_critical_tests_ios_swiftui_allFastlane lanes were missing the|options|block parameter and weren't forwardingdevice: options[:device]torun_ui_tests.The CI workflow (
ui-tests-common.yml) passesdevice:"iPhone 16 Pro (18.5)"on the command line, but these two lanes silently ignored it. Fastlane then fell back to picking whatever simulator it found first — iPhone 14 Pro on iOS 16.4. Running UI tests on iOS 16.4 with Xcode 16.4 triggers the known "Test runner never began executing tests after launching" XCTest connection issue intermittently.Every other UI test lane (
ui_tests_ios_swiftui,ui_tests_ios_swift6,ui_tests_ios_objc,ui_tests_ios_swift) correctly accepts and forwardsoptions[:device]— these two were the only ones missing it.How to verify
The "Test iOS 18 V4 / UI Tests Common" job in the
Test UI Criticalworkflow should now consistently target the correct iOS 18.5 simulator instead of falling back to iOS 16.4.#skip-changelog
Closes #8711