fix: update LoadValidator error message - #8710
Merged
Merged
Conversation
Add unreleased fix entry noting the LoadValidator error message correction from 'same binary' to 'same address space'.
NinjaLikesCheez
added
the
run-full-ci
NinjaLikesCheez
marked this pull request as ready for review
August 6, 2026 15:07
NinjaLikesCheez
requested review from
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
August 6, 2026 15:07
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 06e9762. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 10a3a91 | 1217.42 ms | 1253.64 ms | 36.23 ms |
| 3561152 | 1205.59 ms | 1246.11 ms | 40.52 ms |
| cd4994f | 1220.89 ms | 1252.61 ms | 31.72 ms |
| 7815f8f | 1229.18 ms | 1263.70 ms | 34.52 ms |
| b404da1 | 1231.65 ms | 1263.33 ms | 31.68 ms |
| 3ae2884 | 1224.79 ms | 1257.32 ms | 32.53 ms |
| 2fe9650 | 1228.33 ms | 1260.78 ms | 32.46 ms |
| 13cc136 | 1224.55 ms | 1252.60 ms | 28.05 ms |
| dde298d | 1212.13 ms | 1247.89 ms | 35.76 ms |
| 11b0eef | 1223.81 ms | 1248.48 ms | 24.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 10a3a91 | 24.14 KiB | 1.27 MiB | 1.24 MiB |
| 3561152 | 24.14 KiB | 1.27 MiB | 1.24 MiB |
| cd4994f | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 7815f8f | 24.14 KiB | 1.26 MiB | 1.23 MiB |
| b404da1 | 24.14 KiB | 1.23 MiB | 1.21 MiB |
| 3ae2884 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 2fe9650 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 13cc136 | 24.14 KiB | 1.23 MiB | 1.20 MiB |
| dde298d | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 11b0eef | 24.14 KiB | 1.18 MiB | 1.15 MiB |
In the checkQueue.async closure in Unit_Tests.swift, Swift requires explicit self for all captured properties. loadedMultipleTimesMessage was the only property missing the self. prefix, causing a build error and failing the Duplication V4 CI job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Updates the LaodValidators error message to be more accurate
💡 Motivation and Context
The current message is misleading in that Sentry is in the same address space multiple times (i.e. loaded binaries) not in a single binary
💚 How did you test it?
Closes #8712