feat: promote standalone app start out of experimental - #8715
Open
itaybre wants to merge 4 commits into
Open
Conversation
Move `enableStandaloneAppStartTracing` from `options.experimental` to a top-level option on `Options`.
itaybre
added
the
run-full-ci
itaybre
marked this pull request as ready for review
August 6, 2026 19:54
itaybre
requested review from
a team,
NinjaLikesCheez,
noahsmartin,
philipphofmann and
philprime
as code owners
August 6, 2026 19:54
5 tasks
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+55
to
57
| if options.enableStandaloneAppStartTracing { | ||
| features.append("standaloneAppStartTracing") | ||
| } |
There was a problem hiding this comment.
Bug: Unconditional access to enableStandaloneAppStartTracing will cause a compilation error on macOS and watchOS.
Severity: HIGH
Suggested Fix
Wrap the access to options.enableStandaloneAppStartTracing in SentryEnabledFeaturesBuilder.swift with the same platform-specific conditional compilation block used for its definition: #if (os(iOS) || os(tvOS) || os(visionOS)) && !SENTRY_NO_UI_FRAMEWORK.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: Sources/Swift/Helper/SentryEnabledFeaturesBuilder.swift#L55-L57
Potential issue: The property `enableStandaloneAppStartTracing` is defined within a
conditional compilation block for iOS, tvOS, and visionOS only in `Options.swift`.
However, the code in `SentryEnabledFeaturesBuilder.swift` accesses this property
unconditionally. This will lead to a compilation error when building for other platforms
supported by the SDK, such as macOS or watchOS, because the property will not exist on
the `Options` object for those targets.
Also affects:
Sources/Swift/Options.swift:352~352
Did we get this right? 👍 / 👎 to inform future reviews.
📲 Install BuildsiOS
|
philprime
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableStandaloneAppStartTracingfromoptions.experimentalto a top-level option onOptions(defaultfalse)SentryObjCOptions.h/SentryObjCOptions.swift)Test plan
make build-iospassesSentryAppStartTrackerTests— 25 tests passSentryEnabledFeaturesBuilderTests— 35 tests passmake generate-public-api— needs Xcode 16 (CI will handle)run-full-cilabelCloses #8720