feat: enable logging by default in v10 - #8717
Open
itaybre wants to merge 3 commits into
Open
Conversation
The logging spec v2.0.0 requires enableLogs to default to true. No logs are emitted unless the user explicitly calls SentrySDK.logger or enables a logging integration.
itaybre
added
the
run-full-ci
itaybre
marked this pull request as ready for review
August 7, 2026 03:12
itaybre
requested review from
NinjaLikesCheez,
noahsmartin,
philipphofmann and
philprime
as code owners
August 7, 2026 03:12
Contributor
|
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 10a3a91 | 1217.42 ms | 1253.64 ms | 36.23 ms |
| 3561152 | 1205.59 ms | 1246.11 ms | 40.52 ms |
| cd4994f | 1220.89 ms | 1252.61 ms | 31.72 ms |
| 7815f8f | 1229.18 ms | 1263.70 ms | 34.52 ms |
| b404da1 | 1231.65 ms | 1263.33 ms | 31.68 ms |
| 3ae2884 | 1224.79 ms | 1257.32 ms | 32.53 ms |
| 2fe9650 | 1228.33 ms | 1260.78 ms | 32.46 ms |
| 13cc136 | 1224.55 ms | 1252.60 ms | 28.05 ms |
| dde298d | 1212.13 ms | 1247.89 ms | 35.76 ms |
| 11b0eef | 1223.81 ms | 1248.48 ms | 24.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 10a3a91 | 24.14 KiB | 1.27 MiB | 1.24 MiB |
| 3561152 | 24.14 KiB | 1.27 MiB | 1.24 MiB |
| cd4994f | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 7815f8f | 24.14 KiB | 1.26 MiB | 1.23 MiB |
| b404da1 | 24.14 KiB | 1.23 MiB | 1.21 MiB |
| 3ae2884 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| 2fe9650 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 13cc136 | 24.14 KiB | 1.23 MiB | 1.20 MiB |
| dde298d | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 11b0eef | 24.14 KiB | 1.18 MiB | 1.15 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable
enableLogsby default when building with theSDK_V10compiler flag. This follows the logging spec v2.0.0 which requiresenableLogsto default totrue. No logs are emitted unless the user explicitly callsSentrySDK.loggeror enables a logging integration, so this is safe to flip.Changes
Options.swift: FlipenableLogsdefault fromfalsetotrueunder#if SDK_V10SentryOptionsTest.m: UpdatetestBooleanFieldcall to expectYESunderSDK_V10CHANGELOG_V10.md: Add breaking change entryHow tested
make build-ios FOR_AGENTS=true— builds cleanmake test-ios FOR_AGENTS=true ONLY_TESTING=SentryTests/SentryOptionsTest— 134 tests, 0 failuresCloses COCOA-1421
#skip-changelog