ref: Migrate app state manager to Swift - #8733
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
August 10, 2026 08:27
philprime
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin and
philipphofmann
as code owners
August 10, 2026 08:27
philprime
enabled auto-merge (squash)
August 10, 2026 08:27
9 tasks
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df67624 | 1225.12 ms | 1259.90 ms | 34.78 ms |
| 6e35062 | 1232.19 ms | 1262.91 ms | 30.73 ms |
| 220d7ef | 1238.77 ms | 1267.42 ms | 28.65 ms |
| 4b5a1d7 | 1235.27 ms | 1264.49 ms | 29.22 ms |
| 9319185 | 1223.24 ms | 1249.98 ms | 26.73 ms |
| d0b52d1 | 1227.31 ms | 1258.32 ms | 31.01 ms |
| b6b0d1d | 1236.69 ms | 1270.22 ms | 33.52 ms |
| 5b1c31e | 1221.35 ms | 1246.14 ms | 24.79 ms |
| 9787f05 | 1233.67 ms | 1269.00 ms | 35.33 ms |
| 29d1b7f | 1220.58 ms | 1254.14 ms | 33.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df67624 | 24.14 KiB | 1.14 MiB | 1.12 MiB |
| 6e35062 | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 220d7ef | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| 4b5a1d7 | 24.14 KiB | 1.22 MiB | 1.20 MiB |
| 9319185 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| d0b52d1 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| b6b0d1d | 24.14 KiB | 1.18 MiB | 1.16 MiB |
| 5b1c31e | 24.14 KiB | 1.24 MiB | 1.22 MiB |
| 9787f05 | 24.14 KiB | 1.18 MiB | 1.15 MiB |
| 29d1b7f | 24.14 KiB | 1.26 MiB | 1.23 MiB |
NinjaLikesCheez
approved these changes
Aug 12, 2026
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
philprime
commented
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Migrates the private app-state lifecycle manager from Objective-C into
SentryAppStateManager.The manager now owns lifecycle notification observation and uses a composed dependency-provider interface for its crash reporter, file manager, sysctl wrapper, dispatch queue, and notification center.
💡 Motivation and Context
The Objective-C helper had a single consumer. Inlining its behavior keeps app-state lifecycle logic together while removing the obsolete private Objective-C header and implementation.
💚 How did you test it?
make formatmake analyzemake build-ios FOR_AGENTS=truemake test-ios FOR_AGENTS=true ONLY_TESTING=SentryTests/SentryAppStateManagerTests,SentryTests/SentryAppStartTrackerTests,SentryTests/SentryWatchdogTerminationLogicTests,SentryTests/SentryWatchdogTerminationTrackerTests,SentryTests/SentryWatchdogTerminationIntegrationTests📝 Checklist
sendDefaultPIIis enabled.Closes #8734