feat: add SPM traits for 3rd-party integrations - #8795
Merged
Conversation
Add PrecompiledSentry (default) and SentryFromSource package traits to all 3rd-party integrations so users can select between precompiled xcframeworks and building from source. - Bump swift-tools-version to 6.1 for trait support - Add conditional product dependencies based on active trait - Add conditional imports (Sentry vs SentrySwift) - Add compile-time error if both traits are enabled - Add SentryFromSource trait to CI test matrix
itaybre
requested review from
NinjaLikesCheez,
noahsmartin,
philipphofmann and
philprime
as code owners
August 12, 2026 14:18
3 tasks
itaybre
added
the
run-full-ci
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f16dfe8. Configure here.
philprime
approved these changes
Aug 12, 2026
philprime
left a comment
philprime
left a comment
Member
There was a problem hiding this comment.
LGTM but we need a changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryFromBinary(default) andSentryFromSourcemutually exclusive package traits to all 4 3rd-party integrations (SentryCocoaLumberjack, SentryPulse, SentrySwiftLog, SentrySwiftyBeaver)SentryFromBinary, the default) and building from source (SentryFromSource) viaswift test --traits SentryFromSourceor by enabling the trait in their dependency declarationChanges per integration
SentryvsSentrySPM), andswiftSettingswith trait-based definesimport SentrySwift(from-source) vsimport Sentry(binary)#errorif both traits enabled simultaneouslyCI
traitmatrix dimension (SentryFromBinary,SentryFromSource) to existingtest-integrations-spmjobmatrix.trait == 'SentryFromBinary'Test plan
swift test(defaultSentryFromBinarytrait)swift test --traits SentryFromSource