build(samples): Generate Xcode metadata - #8982
Merged
Merged
Conversation
Move sample Info.plist and entitlements definitions into XcodeGen and ignore the generated files. Add git metadata and debug-symbol upload phases to applicable sample app targets.
philprime
marked this pull request as ready for review
September 8, 2026 13:29
philprime
requested review from
NinjaLikesCheez,
itaybre and
noahsmartin
as code owners
September 8, 2026 13:29
philprime
added
run-full-ci
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
📲 Install BuildsiOS
|
NinjaLikesCheez
approved these changes
Sep 8, 2026
NinjaLikesCheez
left a comment
NinjaLikesCheez
left a comment
Member
There was a problem hiding this comment.
LGTM, but one comment for your consideration
philprime
enabled auto-merge (squash)
September 9, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move sample Info.plist and entitlements definitions into XcodeGen so the YAML specs are the single source of truth. Generated metadata files are now ignored, while applicable app targets inject git information and upload debug symbols during builds.
Verification
make formatmake xcode-cimake analyzeThe workspace-based
iOS-Swiftbuild was also attempted, but remains blocked by the existing duplicate-header collision in shared DerivedData.#skip-changelog
Closes #8983