-
-
Notifications
You must be signed in to change notification settings - Fork 257
fix(twp): Trace propagation in HTTP tracing clients #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2850 +/- ##
==========================================
+ Coverage 87.61% 87.67% +0.06%
==========================================
Files 270 271 +1
Lines 9032 9021 -11
==========================================
- Hits 7913 7909 -4
+ Misses 1119 1112 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2d89fc | 1251.80 ms | 1261.92 ms | 10.11 ms |
ed605cc | 1246.06 ms | 1262.04 ms | 15.98 ms |
c57d3b7 | 1249.92 ms | 1280.31 ms | 30.39 ms |
ea1d45d | 1234.96 ms | 1250.27 ms | 15.31 ms |
c328ffc | 1236.73 ms | 1260.73 ms | 24.00 ms |
6fedcab | 1242.33 ms | 1269.66 ms | 27.33 ms |
3500574 | 1263.02 ms | 1263.73 ms | 0.71 ms |
95c69e3 | 1223.94 ms | 1245.29 ms | 21.35 ms |
ec4c9da | 1228.33 ms | 1261.63 ms | 33.31 ms |
00236a7 | 1250.06 ms | 1274.00 ms | 23.94 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2d89fc | 8.10 MiB | 9.16 MiB | 1.06 MiB |
ed605cc | 8.10 MiB | 9.17 MiB | 1.08 MiB |
c57d3b7 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
ea1d45d | 8.42 MiB | 9.97 MiB | 1.54 MiB |
c328ffc | 8.34 MiB | 9.67 MiB | 1.33 MiB |
6fedcab | 8.32 MiB | 9.50 MiB | 1.18 MiB |
3500574 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
95c69e3 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
ec4c9da | 8.38 MiB | 9.71 MiB | 1.34 MiB |
00236a7 | 8.38 MiB | 9.77 MiB | 1.39 MiB |
Previous results on branch: fix/twp-http-clients
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f8089d | 1239.84 ms | 1256.84 ms | 17.00 ms |
e736ce0 | 1269.02 ms | 1272.84 ms | 3.82 ms |
3f6b431 | 1246.96 ms | 1260.83 ms | 13.87 ms |
b2be39c | 1249.76 ms | 1262.38 ms | 12.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f8089d | 8.43 MiB | 10.00 MiB | 1.57 MiB |
e736ce0 | 8.43 MiB | 10.00 MiB | 1.57 MiB |
3f6b431 | 8.43 MiB | 9.99 MiB | 1.56 MiB |
b2be39c | 8.43 MiB | 10.00 MiB | 1.57 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d61cecf | 339.69 ms | 387.57 ms | 47.88 ms |
a609134 | 350.12 ms | 404.12 ms | 54.00 ms |
6491ebd | 301.74 ms | 351.96 ms | 50.22 ms |
d0312c9 | 354.78 ms | 411.53 ms | 56.75 ms |
c73ab67 | 353.82 ms | 408.71 ms | 54.90 ms |
1bbb79f | 453.04 ms | 490.74 ms | 37.70 ms |
294b7f0 | 367.83 ms | 430.00 ms | 62.17 ms |
7b34d99 | 441.92 ms | 481.40 ms | 39.48 ms |
21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
be1723a | 453.86 ms | 493.64 ms | 39.78 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d61cecf | 6.06 MiB | 7.03 MiB | 995.56 KiB |
a609134 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
6491ebd | 6.15 MiB | 7.13 MiB | 999.96 KiB |
d0312c9 | 6.33 MiB | 7.26 MiB | 949.76 KiB |
c73ab67 | 6.15 MiB | 7.13 MiB | 999.97 KiB |
1bbb79f | 6.49 MiB | 7.57 MiB | 1.08 MiB |
294b7f0 | 6.33 MiB | 7.26 MiB | 950.21 KiB |
7b34d99 | 6.44 MiB | 7.50 MiB | 1.06 MiB |
21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
be1723a | 6.49 MiB | 7.56 MiB | 1.07 MiB |
Previous results on branch: fix/twp-http-clients
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e736ce0 | 458.32 ms | 585.06 ms | 126.74 ms |
3f6b431 | 470.36 ms | 534.40 ms | 64.04 ms |
b2be39c | 449.96 ms | 510.69 ms | 60.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e736ce0 | 6.44 MiB | 7.43 MiB | 1010.27 KiB |
3f6b431 | 6.44 MiB | 7.43 MiB | 1007.37 KiB |
b2be39c | 6.44 MiB | 7.43 MiB | 1010.28 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small suggestion.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps