Tag all spans with thread info #3101
Open
+651
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
==========================================
+ Coverage 87.66% 87.79% +0.12%
==========================================
Files 288 290 +2
Lines 9813 9825 +12
==========================================
+ Hits 8603 8626 +23
+ Misses 1210 1199 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
| 640ad0c | 466.00 ms | 552.67 ms | 86.67 ms |
| 79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
| 575ebaa | 478.00 ms | 585.76 ms | 107.76 ms |
| dbd526b | 504.88 ms | 569.02 ms | 64.15 ms |
| 73a3c38 | 478.18 ms | 526.62 ms | 48.44 ms |
| aeb02f2 | 373.84 ms | 437.00 ms | 63.16 ms |
| 0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 640ad0c | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 575ebaa | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| dbd526b | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 73a3c38 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| aeb02f2 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
buenaflor
requested changes
Jul 22, 2025
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
| ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
| 0fb45d0 | 1273.24 ms | 1286.44 ms | 13.19 ms |
| 2cf9161 | 1248.33 ms | 1266.55 ms | 18.22 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
| 93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
| 6f47800 | 1247.52 ms | 1259.37 ms | 11.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 0fb45d0 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2cf9161 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6f47800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
…/sentry-dart into enha/add-isolate-info-to-spans
buenaflor
reviewed
Jul 29, 2025
Comment on lines
+441
to
+443
| Future<void> _dispatchOnSpanStart(ISentrySpan span) async { | ||
| await _hub.options.lifecycleRegistry.dispatchCallback(OnSpanStart(span)); | ||
| } |
There was a problem hiding this comment.
can we return void and remove the async? we are awaiting here but call unawaited when calling _dispatchOnSpanStart so we could just remove async altogether
Comment on lines
+75
to
+80
| @internal | ||
| class OnSpanStart extends SdkLifecycleEvent { | ||
| OnSpanStart(this.span); | ||
|
|
||
| final ISentrySpan span; | ||
| } |
There was a problem hiding this comment.
Can you add a comment that this triggers only for sampled spans
| /// information to spans when they are started. | ||
| @internal | ||
| class ThreadInfoIntegration implements Integration<SentryFlutterOptions> { | ||
| static const integrationName = 'ThreadInfoIntegration'; |
There was a problem hiding this comment.
Suggested change
| static const integrationName = 'ThreadInfoIntegration'; | |
| static const integrationName = 'ThreadInfo'; |
from now on this should be wtihout the integration suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Tag all spans with thread info
OnSpanStartlifecycle event for tracer span creation💡 Motivation and Context
Closes #2505
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps