Skip to content

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Sep 24, 2025

#skip-changelog

📜 Description

  • Fix warnings in SentryFlutter.kt and SentryFlutterPlugin.kt
  • Bump Kotlin to 1.8 for example app

💡 Motivation and Context

Closes #3197

💚 How did you test it?

Checked linter in Android Studio

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Sep 24, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@denrase denrase marked this pull request as ready for review September 24, 2025 11:37
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (8541716) to head (4de2196).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
+ Coverage   87.84%   89.71%   +1.87%     
==========================================
  Files         290       95     -195     
  Lines       10003     3393    -6610     
==========================================
- Hits         8787     3044    -5743     
+ Misses       1216      349     -867     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase
Copy link
Collaborator Author

denrase commented Sep 30, 2025

@stefanosiano Review pls :)

@denrase denrase merged commit 5d411b0 into main Oct 1, 2025
53 checks passed
@denrase denrase deleted the fix/andorid-warnings branch October 1, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'HubAdapter' is deprecated & 'LoadClass' is deprecated & unsafe use of a nullable receiver of type Thread.UncaughtExceptionHandler

2 participants