Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Profiling index page docs #13198

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

indragiek
Copy link
Member

DESCRIBE YOUR PR

Update existing Profiling index page documentation to be consistent with UX updates for the Continuous & UI Profiling update.

These docs need to go live for April 9th, 2025 when Continuous & UI Profiling are GA.

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 5:09am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 5:09am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 5:09am

Copy link

codecov bot commented Apr 1, 2025

Bundle Report

Changes will decrease total bundle size by 465 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.61MB -459 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.45MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.67kB -0.0%
static/chunks/8931-*.js -3 bytes 397.42kB -0.0%
static/LxKY8OFgvrdwVe2ivAAxy/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/LxKY8OFgvrdwVe2ivAAxy/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/uddJc3Lj6-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/uddJc3Lj6-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 911.63kB -0.0%
9523.js -3 bytes 887.68kB -0.0%
../app/[[...path]]/page.js.nft.json -150 bytes 383.44kB -0.04%
../app/platform-redirect/page.js.nft.json -150 bytes 383.35kB -0.04%
../app/sitemap.xml/route.js.nft.json -150 bytes 381.32kB -0.04%

@@ -21,83 +21,64 @@ description: "Profiling offers a deeper level of visibility on top of traditiona

</Alert>

Sentry's profiling feature builds upon our established [Insights](/product/insights) capabilities to provide precise code-level visibility into application execution in a production environment. Profiling provides context at a deeper level than traditional tracing, enabling you to visualize the precise details of the call stack without the need for custom instrumentation. With Profiling you can quickly identify hot paths in your code and understand potential performance bottlenecks, enabling you to build in [performance as a feature](https://blog.codinghorror.com/performance-is-a-feature/) from day one.
Sentry’s Profiling products provide precise, code-level visibility into application execution in a production environment. Profiling provides context at a deeper level than traditional [tracing](/concepts/key-terms/tracing/), enabling you to visualize call stacks on every thread without the need for custom instrumentation. With Profiling you can quickly identify hot paths in your code and understand potential performance bottlenecks, enabling you to build in [performance as a feature](https://blog.codinghorror.com/performance-is-a-feature/) from day one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indragiek - is there an opportunity earlier in this page to more explicitly call out a "When would you use Profiling" so that if someone lands on this page, they immediately know why to dig in? We talk about it throughout the page (especially in that paragraph), and the content is incredibly good - but in other parts of the page it might take some digging.

We hit some of the first sentences of this in the description of the index section, so it might be a good idea to replace some of the directly repetitive with some direct bullets around when to use profiling -

Sentry's profiling products are useful when you...

  • Want a deeper view into the individual calls that are causing performance issues
  • Want to understand the performance of individual calls within your application code
  • Want to visualize the call stack of every thread without custom instrumentation
  • Need to identify hot paths in your code and how they create performance bottlenecks

Profiling enables you to build in... etc

Food for though; intention is to get people to immediately connect with why they are here and what they are going to do.

@codyde
Copy link
Contributor

codyde commented Apr 3, 2025

This looks great @indragiek! I had one comment on a suggestion to create a more direct call out of "when to use profiling"; but other than that - this is awesome.


## Profiling Summary Page
The **Aggregate Flamegraph** tab shows a [flame graph](/product/explore/profiling/flame-charts-graphs) with aggregated information on the frequency of code paths within the selected projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you are using both 'flamegraph' and 'flame graph' here, is there a distinction here or can we keep it to one convention?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we've been inconsistent with that in the ast, the one we want to consolidate on is "flame graph" but there are places in the product where we still use the other one (e.g. the Aggregate Flamegraph tab referenced here). I believe this might be the only place in the product remaining that uses the wrong convention. I'll do an audit later and once we fix those in the product I'll open a separate docs PR to change it here and all the other places where it's inconsistent.

Thank you for the attention to detail!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments, but overall looks good!

Copy link
Contributor

@codyde codyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Love the changes. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants