Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test Ben.Demystifier.Test.NonThrownException.Current #1383

Closed
bruno-garcia opened this issue Dec 13, 2021 · 2 comments · Fixed by #1389
Closed

Flaky test Ben.Demystifier.Test.NonThrownException.Current #1383

bruno-garcia opened this issue Dec 13, 2021 · 2 comments · Fixed by #1389

Comments

@bruno-garcia
Copy link
Member

Following test became flaky once we added .NET 6 support:

xUnit.net 00:00:18.53]     Ben.Demystifier.Test.NonThrownException.Current [FAIL]
Error: Ben.Demystifier.Test.NonThrownException.Current: Assert.Equal() Failure
  Failed Ben.Demystifier.Test.NonThrownException.Current [11 ms]
  Error Message:
   Assert.Equal() Failure
Expected: String[] ["   at bool System.Threading.ThreadPoolWorkQueue.Di"..., "   at void System.Threading.PortableThreadPool+Wor"..., "   at void System.Threading.Thread.StartCallback()"]
Actual:   WhereArrayIterator<String> ["   at bool System.Threading.ThreadPoolWorkQueue.Di"..., "   at void System.Threading.PortableThreadPool+Wor"...]
  Stack Trace:
     at Ben.Demystifier.Test.NonThrownException.Current() in /home/runner/work/sentry-dotnet/sentry-dotnet/modules/Ben.Demystifier/test/Ben.Demystifier.Test/NonThrownException.cs:line 110
--- End of stack trace from previous location ---

Failed!  - Failed:     1, Passed:  1044, Skipped:     1, Total:  1046, Duration: 19 s - /home/runner/work/sentry-dotnet/sentry-dotnet/test/Sentry.Tests/bin/Release/net6.0/Sentry.Tests.dll (net6.0)

@bruno-garcia
Copy link
Member Author

@SimonCropp we could just remove these tests at least until we resolve this. If not forever.

Linking for reference: benaadams/Ben.Demystifier#186

@SimonCropp
Copy link
Contributor

ok my theory on a thread sleep fixing the issue did not work. so my vote is to no longer run these tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants