Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont run Demystifier.Test #1389

Merged
merged 1 commit into from
Dec 14, 2021
Merged

dont run Demystifier.Test #1389

merged 1 commit into from
Dec 14, 2021

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Dec 14, 2021 •
edited
Loading

#skip-changelog

fixes #1383

@bruno-garcia
Copy link
Member

When we change the git sha of the submodule, we must run tests in the Ben.Demystifier solution

"Can't forget" (if depends on me, I'll forget) 😢

@SimonCropp
Copy link
Contributor Author

When we change the git sha of the submodule, we must run tests in the Ben.Demystifier solution

i dont understand that

@SimonCropp SimonCropp merged commit 2e6f9c7 into main Dec 14, 2021
@SimonCropp SimonCropp deleted the dont-run-Demystifier.Test branch December 14, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test Ben.Demystifier.Test.NonThrownException.Current
2 participants
@SimonCropp @bruno-garcia