Move setting /NODEFAULTLIB:MSVCRT LinkerArg to windows-specific targets in Sentry.Native.targets #4760
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in Sentry.Native.targets Before the flag was added even if you built for an android RID on windows, causing an error.
akoeplinger
requested review from
Flash0ver and
jamescrosswell
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
=======================================
Coverage 73.85% 73.85%
=======================================
Files 485 485
Lines 17689 17689
Branches 3496 3496
=======================================
+ Hits 13064 13065 +1
+ Misses 3765 3763 -2
- Partials 860 861 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the flag was added even if you built for an android RID on windows, causing an error.