SentryGraphQLHttpFailedRequestHandler improved issue grouping. #4762
+118
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsampson
requested review from
Flash0ver and
jamescrosswell
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| #endif | ||
| // Wrap in a new exception to preserve the stack trace when thrown and caught. | ||
| // The inner exception will have the full stack trace for better issue grouping. | ||
| throw new GraphQLHttpRequestException(errorMessage, exception); |
There was a problem hiding this comment.
Bug: Inner exception missing stack trace on pre-.NET 5
On pre-.NET 5 platforms, the inner exception won't have a stack trace because it's never thrown and SetCurrentStackTrace isn't available. The wrapper exception at line 45 only captures a minimal stack trace from the immediate throw/catch within the same method. To match the HTTP handler pattern, the inner exception should be thrown and caught on pre-.NET 5 platforms before wrapping, similar to the try-catch pattern used in SentryHttpFailedRequestHandler.
Contributor
Author
There was a problem hiding this comment.
I think that's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same improvements for GraphQL as in this PR for plain HTTP: #4724