-
-
Notifications
You must be signed in to change notification settings - Fork 60
feat: Update JavaScript SDKs to v10 #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timfish heads-up: We have to ship an important fix in browser SDKs with v10.4.0 which I think would be great to get into the electron v10 bump right from the start.
I think on the renderer side, we're covered, given my fix applies to BrowserClient
. But we should also adjust the behaviour in the main process where we call the now deprecated addAutoIpAddressToUser
function. Not sure if adjustment is required elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review! LGTM, thanks for making the IP changes!
Uh oh!
There was an error while loading. Please reload this page.