Skip to content

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Aug 1, 2025

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timfish heads-up: We have to ship an important fix in browser SDKs with v10.4.0 which I think would be great to get into the electron v10 bump right from the start.

I think on the renderer side, we're covered, given my fix applies to BrowserClient. But we should also adjust the behaviour in the main process where we call the now deprecated addAutoIpAddressToUser function. Not sure if adjustment is required elsewhere.

@timfish timfish changed the title feat: Update JavaScript SDKs to v10.0.0 feat: Update JavaScript SDKs to v10 Aug 13, 2025
@timfish timfish requested review from Lms24 and AbhiPrasad August 27, 2025 18:44
@timfish timfish marked this pull request as ready for review August 27, 2025 21:48
@timfish timfish requested a review from mydea September 3, 2025 07:23
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review! LGTM, thanks for making the IP changes!

@timfish timfish merged commit 08622ca into master Sep 3, 2025
64 of 67 checks passed
@timfish timfish deleted the fea/javascript-v10 branch September 3, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make logging use a non experimental flag
2 participants