-
-
Notifications
You must be signed in to change notification settings - Fork 455
Add more AI rules #4636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add more AI rules #4636
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add more AI rules ([#4636](https://github.com/getsentry/sentry-java/pull/4636)) If none of the above apply, you can opt out of this check by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the comments are blocking, just things I noticed while reading that you can change if there's time.
|
||
The samples in the `sentry-samples` directory are used to run end to end tests against them. | ||
|
||
There is a python script (`system-test-runner.py`) that can be used to run one (using `--module SAMPLE_NAME`) or all (using `--all` system tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a python script (`system-test-runner.py`) that can be used to run one (using `--module SAMPLE_NAME`) or all (using `--all` system tests. | |
There is a python script (`system-test-runner.py`) that can be used to run one (using `--module SAMPLE_NAME`) or all (using `--all`) system tests. |
|
||
`TestHelper` has a lot of helper methods for asserting, e.g. by span name, log body etc. | ||
|
||
The end to end tests either expect the system under test to either be running (for server applications) or call `java -jar` to execute a CLI system under test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence confused me on first read.
The end to end tests either expect the system under test to either be running (for server applications) or call `java -jar` to execute a CLI system under test. | |
The end to end tests either expect the system under test to either be running on a server or call `java -jar` to execute a CLI system under test. |
|
||
If `globalHubMode` is enabled, the SDK avoids forking scopes. | ||
|
||
This means, retrieving current scopes on a thread where specific scopes for that thread exist yet, the root scopes are not forked but returned directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what is meant here. Does the rewrite below capture the meaning?
This means, retrieving current scopes on a thread where specific scopes for that thread exist yet, the root scopes are not forked but returned directly. | |
This means, retrieving current scopes on a thread where specific scopes do not exist yet for the thread, the root scopes are not forked but returned directly. |
📜 Description
Rules to help AI understand the SDK.
This is mostly intended for development on the SDK.
In the future, we can add more rules that are customer facing too.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps