feat(nextjs): Record turbopack as tag
#15928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Tricky because it relies very strongly on Next.js versions and stuff. |
AbhiPrasad
reviewed
Apr 1, 2025
| try { | ||
| // @ts-expect-error `process.turbopack` is a magic string that will be replaced by Next.js | ||
| if (process.turbopack) { | ||
| getGlobalScope().setTag('turbopack', true); |
There was a problem hiding this comment.
hmm are we sure we want to set a tag over a context here? Is there value in making this searchable?
There was a problem hiding this comment.
I say yes - for now. Sigrid is working on some stuff in the protocol that will allow us to send stuff like this in a more structured way. It will be invaluable for us in the transitionary period when turbopack ships and we have to debug potential issues with the SDK.
mydea
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tag can be useful for troubleshooting inside the product.
Note that the
process.turbopackflag is only available in code bundled by Next.js.