add @sentry/tanstackstart-solid
#15931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Apr 1, 2025
There was a problem hiding this comment.
The repo uses yarn v1, you'll need to re-run with that to get the tests going
There was a problem hiding this comment.
The issue I face is that I can't build the /core package. I get with yarn 1.x + node 20 (as specified in package.json):
src/index.ts → build/cjs...
[!] (plugin sucrase) Error: value.disableES2019Transforms is extraneous
src/index.ts
at new VError (/Users/admin/repos/sentry-javascript/node_modules/ts-interface-checker/dist/util.js:24:28)
at DetailContext.getError (/Users/admin/repos/sentry-javascript/node_modules/ts-interface-checker/dist/util.js:96:16)
at Checker._doCheck (/Users/admin/repos/sentry-javascript/node_modules/ts-interface-checker/dist/index.js:200:29)
at Checker.strictCheck (/Users/admin/repos/sentry-javascript/node_modules/ts-interface-checker/dist/index.js:122:68)
at validateOptions (/Users/admin/repos/sentry-javascript/node_modules/sucrase/dist/Options.js:100:18)
at transform (/Users/admin/repos/sentry-javascript/node_modules/sucrase/dist/index.js:36:28)
at Object.transform (file:///Users/admin/repos/sentry-javascript/dev-packages/rollup-utils/plugins/vendor/sucrase-plugin.mjs:65:22)
at /Users/admin/repos/sentry-javascript/node_modules/rollup/dist/shared/rollup.js:3368:40
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "build:transpile" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
|
Hi, we really appreciate the PR, but as of now, we decided not to merge it because we cannot justify the maintenance for the still very-low usage of TanStack Start + Solid. We can reconsider in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Port of the
@sentry/tanstackstart-reactto `@sentry/tanstackstart-solidContributing guidelines and verify:
yarn lint) & (yarn test).I'm having some issues running the tests - and I'd like to sanity check if the CI see the same as I do